Skip to content

Commit 77d0655

Browse files
committed
Upgrade go version
1 parent 97a80a7 commit 77d0655

File tree

10 files changed

+17
-36
lines changed

10 files changed

+17
-36
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
## WHAT
22

3-
- Write the change being made with this pull request.
3+
<!-- Write the change being made with this pull request. -->
44

55
## WHY
6-
7-
- Write the motivation why you submit this pull request.
6+
<!-- Write the motivation why you submit this pull request. -->

.github/workflows/actions.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,20 +13,20 @@ jobs:
1313
name: Lint
1414
runs-on: ubuntu-latest
1515
steps:
16-
- uses: actions/checkout@v3
17-
- uses: golangci/golangci-lint-action@v3
16+
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
17+
- uses: golangci/golangci-lint-action@55c2c1448f86e01eaae002a5a3a9624417608d84 # v6.5.2
1818
with:
19-
version: v1.52.2
19+
version: v1.64.8
2020
test:
2121
name: Test
2222
runs-on: ubuntu-latest
2323
strategy:
2424
matrix:
2525
go: [ 'stable', 'oldstable' ]
2626
steps:
27-
- uses: actions/checkout@v3
28-
- uses: actions/setup-go@v3
27+
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
28+
- uses: actions/setup-go@0aaccfd150d50ccaeb58ebd88d36e91967a5f35b # v5.4.0
2929
with:
3030
go-version: ${{ matrix.go }}
3131
- run: go test -race -covermode=atomic -coverprofile=coverage.txt ./...
32-
- uses: codecov/codecov-action@v3
32+
- uses: codecov/codecov-action@0565863a31f2c772f9f0395002a31e3f06189574 # v5.4.0

.golangci.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
linters-settings:
22
errcheck:
3-
check-type-asserts: true
3+
check-type-assertions: true
44
check-blank: true
55
misspell:
66
locale: US
@@ -12,9 +12,10 @@ linters-settings:
1212
linters:
1313
enable-all: true
1414
disable:
15-
- gomnd
15+
- mnd
1616
- varnamelen
1717
- wsl
18+
- recvcheck
1819

1920
issues:
2021
exclude-rules:
@@ -27,3 +28,5 @@ issues:
2728
- dupl
2829
- ifshort
2930
- funlen
31+
- exhaustruct
32+
- depguard

cmd/checkdigit/main.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package main
22

3+
//nolint: depguard
34
import (
45
"flag"
56
"fmt"

damm_test.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,6 @@ func TestDamm_Verify(t *testing.T) {
3737
}
3838

3939
for name, c := range cases {
40-
c := c
41-
4240
t.Run(name, func(t *testing.T) {
4341
t.Parallel()
4442

@@ -92,8 +90,6 @@ func TestDamm_Generate(t *testing.T) {
9290
}
9391

9492
for name, c := range cases {
95-
c := c
96-
9793
t.Run(name, func(t *testing.T) {
9894
t.Parallel()
9995

go.mod

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
module github.com/osamingo/checkdigit
22

3-
go 1.18
3+
go 1.24
4+
5+
toolchain go1.24.1

gtin_test.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,6 @@ func TestGtin_Verify(t *testing.T) {
5656
}
5757

5858
for name, c := range cases {
59-
c := c
60-
6159
t.Run(name, func(t *testing.T) {
6260
t.Parallel()
6361

@@ -126,8 +124,6 @@ func TestGtin_Generate(t *testing.T) {
126124
}
127125

128126
for name, c := range cases {
129-
c := c
130-
131127
t.Run(name, func(t *testing.T) {
132128
t.Parallel()
133129

isbn_test.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,6 @@ func TestIsbn10_Verify(t *testing.T) {
4343
}
4444

4545
for name, c := range cases {
46-
c := c
47-
4846
t.Run(name, func(t *testing.T) {
4947
t.Parallel()
5048

@@ -98,8 +96,6 @@ func TestIsbn10_Generate(t *testing.T) {
9896
}
9997

10098
for name, c := range cases {
101-
c := c
102-
10399
t.Run(name, func(t *testing.T) {
104100
t.Parallel()
105101

@@ -151,8 +147,6 @@ func TestIsbn13_Verify(t *testing.T) {
151147
}
152148

153149
for name, c := range cases {
154-
c := c
155-
156150
t.Run(name, func(t *testing.T) {
157151
t.Parallel()
158152

@@ -206,8 +200,6 @@ func TestIsbn13_Generate(t *testing.T) {
206200
}
207201

208202
for name, c := range cases {
209-
c := c
210-
211203
t.Run(name, func(t *testing.T) {
212204
t.Parallel()
213205

luhn_test.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,6 @@ func TestLuhn_Verify(t *testing.T) {
3737
}
3838

3939
for name, c := range cases {
40-
c := c
41-
4240
t.Run(name, func(t *testing.T) {
4341
t.Parallel()
4442

@@ -92,8 +90,6 @@ func TestLuhn_Generate(t *testing.T) {
9290
}
9391

9492
for name, c := range cases {
95-
c := c
96-
9793
t.Run(name, func(t *testing.T) {
9894
t.Parallel()
9995

verhoeff_test.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,6 @@ func TestVerhoeff_Verify(t *testing.T) {
3737
}
3838

3939
for name, c := range cases {
40-
c := c
41-
4240
t.Run(name, func(t *testing.T) {
4341
t.Parallel()
4442

@@ -84,8 +82,6 @@ func TestVerhoeff_Generate(t *testing.T) {
8482
}
8583

8684
for name, c := range cases {
87-
c := c
88-
8985
t.Run(name, func(t *testing.T) {
9086
t.Parallel()
9187

0 commit comments

Comments
 (0)