Skip to content

Commit 2b3191a

Browse files
authored
Merge pull request #541 from osano/gulp4
upgrade gulp & made package changes to reflect Osano as repo owner
2 parents 5ee2890 + 080a5f9 commit 2b3191a

File tree

9 files changed

+4752
-53
lines changed

9 files changed

+4752
-53
lines changed

.gitignore

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
node_modules/
22
.idea
33
.vscode
4-
.code-workspace
4+
*.code-workspace
55
.DS_Store
6-
build-verify/
7-
build/
6+
build-verify/

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
language: node_js
22
node_js:
3-
- '4.1'
3+
- 'lts/*'
44
install:
55
- npm install
66
- npm install -g gulp

bower.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "cookieconsent",
3-
"version": "3.1.0",
3+
"version": "3.1.1",
44
"homepage": "http://cookieconsent.osano.com/",
55
"authors": ["Osano"],
66
"description": "Osano cookie consent plugin",

build/cookieconsent.min.css

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

build/cookieconsent.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gulpfile.js

Lines changed: 20 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,19 @@
1-
var gulp = require('gulp');
2-
var concat = require('gulp-concat');
3-
var rename = require('gulp-rename');
4-
var minifyJS = require('gulp-uglify');
5-
var minifyCSS = require('gulp-minify-css');
6-
var deleteDirs = require('del');
7-
var runSequence = require('run-sequence');
8-
var autoprefixer = require('gulp-autoprefixer');
9-
var bump = require('gulp-bump');
10-
var yargs = require('yargs');
11-
var diff = require('gulp-diff');
1+
const gulp = require('gulp');
2+
const concat = require('gulp-concat');
3+
const minifyJS = require('gulp-terser');
4+
const minifyCSS = require('gulp-clean-css');
5+
const deleteDirs = require('del');
6+
const autoprefixer = require('gulp-autoprefixer');
7+
const bump = require('gulp-bump');
8+
const yargs = require('yargs');
9+
const diff = require('gulp-diff-4');
1210

1311

14-
var buildFolder = './build';
15-
var jsBuildFiles = [
12+
let buildFolder = './build';
13+
const jsBuildFiles = [
1614
'./src/cookieconsent.js'
1715
];
18-
var cssBuildFiles = [
16+
const cssBuildFiles = [
1917
// defined explicitly so they are combined in order
2018
'./src/styles/animation.css',
2119
'./src/styles/base.css',
@@ -46,38 +44,33 @@ gulp.task('minify:css', function () {
4644
.pipe(gulp.dest(buildFolder)); // save under a new name
4745
});
4846

49-
gulp.task('bump', function(callback) {
47+
gulp.task('bump', function() {
5048
return gulp.src(['./bower.json', './package.json'])
5149
.pipe(bump({'version': yargs.argv.tag}))
5250
.pipe(gulp.dest('./'))
5351
});
5452

55-
gulp.task('build', function(callback) {
56-
return runSequence('cleanup:begin', 'minify:js', 'minify:css', callback);
57-
});
53+
gulp.task('build', gulp.series('cleanup:begin', 'minify:js', 'minify:css'));
5854

59-
gulp.task('verify', function(callback) {
55+
gulp.task('verify', function() {
6056
buildFolder = "./build-verify";
61-
return runSequence('cleanup:begin', 'minify:js', 'minify:css', 'verify:diff', callback);
57+
return new Promise(gulp.series('cleanup:begin', 'minify:js', 'minify:css', 'verify:diff'));
6258
});
6359

64-
gulp.task('verify:diff', function(callback) {
60+
gulp.task('verify:diff', function() {
6561
return gulp.src('./build/*')
6662
.pipe(diff('./build-verify'))
6763
.pipe(diff.reporter({ fail: true }));
6864
});
6965

70-
gulp.task('build:release', function(callback) {
66+
gulp.task('build:release', function() {
7167
if (yargs.argv.tag===undefined) {
7268
throw "A version number (e.g. 3.0.1) is required to build a release of cookieconsent"
7369
}
7470

75-
return runSequence('build', 'bump', callback)
71+
return new Promise(gulp.series('build', 'bump'));
7672
});
7773

7874
gulp.task('watch', function() {
7975
gulp.watch(cssBuildFiles.concat(jsBuildFiles), ['build']);
80-
});
81-
82-
function _minify(opts) {
83-
}
76+
});

0 commit comments

Comments
 (0)