Skip to content

Commit 736dd29

Browse files
committed
testing: Do not allocate a pseudo-TTY for container
The created pseudo-tty creates problems for dnf (and dnf only). For some reason dnf doesn't know how to work with it and fails: terminate called after throwing an instance of 'std::length_error' what(): basic_string::_M_replace_aux Aborted (core dumped) dnf -y install ... The problem doesn't seem to be solved. As a workaround, we will not create pseudo-tty for containers. Link: https://lists.fedoraproject.org/archives/list/[email protected]/thread/4I66OECABACGM2VNC3IZQDHJSZKCH6LV/#QW2BVXGUDCZC2EWJQKTYFHEIGPIL4WWY Signed-off-by: Alexey Gladkov <[email protected]>
1 parent 6dbfd9b commit 736dd29

File tree

5 files changed

+11
-11
lines changed

5 files changed

+11
-11
lines changed

testing/sh-functions

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ pack_sysimage()
7272
/sbin/mke2fs -t ext3 -L SYSIMAGE -d /image /host/$workdir/sysimage.img
7373
EOF
7474

75-
run podman run --rm -ti \
75+
run podman run --rm -i \
7676
--mount="type=image,src=localhost/mi-$VENDOR:sysimage,dst=/image" \
7777
--mount="type=tmpfs,destination=/image$builddir" \
7878
--mount="type=bind,src=$topdir/.build/dest,dst=/image$builddir/.build/dest" \

testing/testing-altlinux-local

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ for step in "$@"; do
7272
fi
7373
EOF
7474

75-
run podman run --rm -ti \
75+
run podman run --rm -i \
7676
--volume="$topdir:$builddir" \
7777
"$IMAGE" "$builddir/$workdir/run.sh"
7878

@@ -150,7 +150,7 @@ for step in "$@"; do
150150
cp -L /boot/initrd.img $builddir/$workdir/boot-ks-initrd.img
151151
EOF
152152

153-
podman run --rm -ti \
153+
podman run --rm -i \
154154
--volume="$topdir:$builddir" \
155155
"$IMAGE" "$builddir/$workdir/run.sh"
156156

testing/testing-altlinux-sshfs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ for step in "$@"; do
7474
fi
7575
EOF
7676

77-
run podman run --rm -ti \
77+
run podman run --rm -i \
7878
--volume="$topdir:$builddir" \
7979
"$IMAGE" "$builddir/$workdir/run.sh"
8080

@@ -135,7 +135,7 @@ for step in "$@"; do
135135

136136
gh_group_start "adding make-initrd binaries"
137137

138-
run podman run --rm -ti \
138+
run podman run --rm -i \
139139
--mount="type=image,src=localhost/mi-$TESTNAME-$VENDOR:sysimage,dst=/image" \
140140
--mount="type=tmpfs,destination=/image$builddir" \
141141
--mount="type=bind,src=$topdir/.build/dest,dst=/image$builddir/.build/dest" \
@@ -187,7 +187,7 @@ for step in "$@"; do
187187
cp -L /boot/initrd.img $builddir/$workdir/sshfsroot-initrd.img
188188
EOF
189189

190-
run podman run --rm -ti \
190+
run podman run --rm -i \
191191
--volume="$topdir:$builddir" \
192192
"$IMAGE" "$builddir/$workdir/run.sh"
193193

@@ -242,7 +242,7 @@ for step in "$@"; do
242242

243243
run podman rm -i -f sshd
244244

245-
run podman run --rm -ti --name="sshd" \
245+
run podman run --rm -i --name="sshd" \
246246
--network=host \
247247
--volume="$top_workdir/sysimage:/data/incoming" \
248248
--volume="$topdir:$builddir" \

testing/testing-fedora-local

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ for step in "$@"; do
7070
exit 1
7171
fi
7272
EOF
73-
run podman run --rm -ti \
73+
run podman run --rm -i \
7474
--volume="$topdir:$builddir" \
7575
"$IMAGE" "$builddir/$workdir/run.sh"
7676

@@ -158,7 +158,7 @@ for step in "$@"; do
158158
cp -L /boot/initrd-ks.img $builddir/$workdir/boot-ks-initrd.img
159159
EOF
160160

161-
podman run --rm -ti \
161+
podman run --rm -i \
162162
--volume="$topdir:$builddir" \
163163
"$IMAGE" "$builddir/$workdir/run.sh"
164164

testing/testing-ubuntu-local

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ for step in "$@"; do
6262
exit 1
6363
fi
6464
EOF
65-
run podman run --rm -ti \
65+
run podman run --rm -i \
6666
--volume="$topdir:$builddir" \
6767
"$IMAGE" "$builddir/$workdir/run.sh"
6868

@@ -139,7 +139,7 @@ for step in "$@"; do
139139
cp -L /boot/initrd-ks.img $builddir/$workdir/boot-ks-initrd.img
140140
EOF
141141

142-
podman run --rm -ti \
142+
podman run --rm -i \
143143
--volume="$topdir:$builddir" \
144144
"$IMAGE" "$builddir/$workdir/run.sh"
145145

0 commit comments

Comments
 (0)