Skip to content

Commit 880423e

Browse files
committed
guess: Do not hardcode filenames with guessed results
Signed-off-by: Alexey Gladkov <gladkov.alexey@gmail.com>
1 parent dd33718 commit 880423e

File tree

2 files changed

+13
-11
lines changed

2 files changed

+13
-11
lines changed

mk/guess.mk.in

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,6 @@ PHONY += prepare-guess
4343

4444
prepare-guess: check-for-root
4545
@mkdir $(verbose3) -m 755 -p -- $(GUESSDIR)
46-
@for n in modules:rescue modules:add modalias:rescue modalias:add opt-modules:add opt-modalias:add features; do \
47-
:>> "$(GUESSDIR)/guess:$$n"; \
48-
done
4946

5047
include \
5148
$(sort $(filter-out \

tools/guess-config

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,20 @@ modules_fmt() {
1414
fmt -u -w60
1515
}
1616

17-
print_vars() {
18-
f="$guessdir/guess:variables"
17+
file_is_not_empty() {
18+
local m
19+
while [ "$#" -gt 0 ]; do
20+
[ ! -s "$1" ] || return 0
21+
shift
22+
done
23+
return 1
24+
}
1925

20-
[ "$(cat "$f":* 2>/dev/null |wc -l)" != "0" ] ||
26+
print_vars() {
27+
file_is_not_empty "$guessdir/guess:variables":* ||
2128
return 0
2229

23-
for m in "$f":*; do
30+
for m in "$guessdir/guess:variables":*; do
2431
[ -s "$m" ] ||
2532
continue
2633
n="${m##*:}"
@@ -35,14 +42,12 @@ print_vars() {
3542
}
3643

3744
print_list() {
38-
f="$guessdir/guess:$2"
39-
40-
[ "$(cat "$f"* |wc -l)" != "0" ] ||
45+
file_is_not_empty "$guessdir/guess:$2":* "$guessdir/guess:$2" ||
4146
return 0
4247

4348
printf '%s += \\\n' "$1"
4449

45-
for m in "$f:"* "$f"; do
50+
for m in "$guessdir/guess:$2":* "$guessdir/guess:$2"; do
4651
[ -s "$m" ] ||
4752
continue
4853

0 commit comments

Comments
 (0)