Skip to content

Commit 06c0fd4

Browse files
cgwaltersmvo5
authored andcommitted
Clarify we build disk images
I almost always stop people who say "image" without qualification because disk images are very different from container images. There's a lingering confusion that bootc-image-builder builds bootc images, which is not true... Signed-off-by: Colin Walters <[email protected]>
1 parent f41cfaf commit 06c0fd4

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

bib/cmd/bootc-image-builder/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -468,7 +468,7 @@ func cmdBuild(cmd *cobra.Command, args []string) error {
468468
return fmt.Errorf("cannot save manifest: %w", err)
469469
}
470470

471-
pbar.SetPulseMsgf("Image building step")
471+
pbar.SetPulseMsgf("Disk image building step")
472472
pbar.SetMessagef("Building %s", manifest_fname)
473473

474474
var osbuildEnv []string

test/test_progress.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ def test_progress_debug(tmp_path, build_fake_container):
2929
res = subprocess.run(cmdline, capture_output=True, check=True, text=True)
3030
assert res.stderr.count("Start progressbar") == 1
3131
assert res.stderr.count("Manifest generation step") == 1
32-
assert res.stderr.count("Image building step") == 1
32+
assert res.stderr.count("Disk image building step") == 1
3333
assert res.stderr.count("Build complete") == 1
3434
assert res.stderr.count("Stop progressbar") == 1
3535
assert res.stdout.strip() == ""

0 commit comments

Comments
 (0)