Skip to content

Commit c8315dc

Browse files
supakeenmvo5
authored andcommitted
main: drop rootfs cross-arch disable
All platforms where `bootc-image-builder` runs that have `qemu-user` available have upgrade to a version >= 9.1.0. Signed-off-by: Simon de Vlieger <[email protected]>
1 parent ccac118 commit c8315dc

File tree

2 files changed

+1
-14
lines changed

2 files changed

+1
-14
lines changed

bib/cmd/bootc-image-builder/main.go

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -278,18 +278,6 @@ func manifestFromCobra(cmd *cobra.Command, args []string, pbar progress.Progress
278278
return nil, nil, fmt.Errorf(`no default root filesystem type specified in container, please use "--rootfs" to set manually`)
279279
}
280280
}
281-
282-
// TODO: on a cross arch build we need to be conservative, i.e. we can
283-
// only use the default ext4 because if xfs is select we run into the
284-
// issue that mkfs.xfs calls "ioctl(BLKBSZSET)" which is missing in
285-
// qemu-user.
286-
// The fix has been merged upstream https://www.mail-archive.com/[email protected]/msg1037409.html
287-
// and is expected to be included in v9.1.0 https://github.com/qemu/qemu/commit/e6e903db6a5e960e595f9f1fd034adb942dd9508
288-
// Remove the following condition once we update to qemu-user v9.1.0.
289-
if cntArch != arch.Current() && rootfsType != "ext4" {
290-
logrus.Warningf("container preferred root filesystem %q cannot be used during cross arch build", rootfsType)
291-
rootfsType = "ext4"
292-
}
293281
}
294282
// Gather some data from the containers distro
295283
sourceinfo, err := source.LoadInfo(container.Root())

test/test_manifest.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -556,8 +556,7 @@ def test_manifest_fs_customizations_xarch(tmp_path, build_container, fscustomiza
556556
"manifest", f"{container_ref}",
557557
])
558558

559-
# cross-arch builds only support ext4 (for now)
560-
assert_fs_customizations(fscustomizations, "ext4", output)
559+
assert_fs_customizations(fscustomizations, rootfs, output)
561560

562561

563562
def find_grub2_iso_stage_from(manifest_str):

0 commit comments

Comments
 (0)