Skip to content

Commit 81d7e26

Browse files
mvo5lzap
authored andcommitted
cmd: move awscloudNewUploader back into upload.go
During the merge of the bootc-image-builder code into bib (PR#374) a function accidentially moved from `upload.go` into `bib_main.go`. This was a mistake and this commit moves it back into the right place. Thanks to Thozza for finding this [0] [0] #374 (comment)
1 parent 9163983 commit 81d7e26

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

cmd/image-builder/bib_main.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -219,8 +219,6 @@ func bibCmdManifest(cmd *cobra.Command, args []string) error {
219219
return nil
220220
}
221221

222-
var awscloudNewUploader = awscloud.NewUploader
223-
224222
func handleAWSFlags(cmd *cobra.Command) (cloud.Uploader, error) {
225223
imgTypes, _ := cmd.Flags().GetStringArray("type")
226224
region, _ := cmd.Flags().GetString("aws-region")

cmd/image-builder/upload.go

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,13 @@ var ErrUploadConfigNotProvided = errors.New("missing all upload configuration")
3131
// ErrUploadTypeUnsupported is returned when the upload type is not supported
3232
var ErrUploadTypeUnsupported = errors.New("unsupported type")
3333

34-
var libvirtNewUploader = libvirt.NewUploader
35-
var openstackNewUploader = openstack.NewUploader
36-
var ibmNewUploader = ibmcloud.NewUploader
34+
// uploader constructors that are mocked in tests
35+
var (
36+
awscloudNewUploader = awscloud.NewUploader
37+
libvirtNewUploader = libvirt.NewUploader
38+
openstackNewUploader = openstack.NewUploader
39+
ibmNewUploader = ibmcloud.NewUploader
40+
)
3741

3842
func uploadImageWithProgress(uploader cloud.Uploader, imagePath string) error {
3943
f, err := os.Open(imagePath)

0 commit comments

Comments
 (0)