Standardise on-prem API error handling and add typeguards #14722
dev-checks.yml
on: pull_request
Build Check
1m 16s
ESLint
1m 8s
Circular Dependencies Check
44s
Manual API Changes Check
42s
Annotations
4 errors and 14 warnings
|
ESLint
Process completed with exit code 1.
|
|
ESLint:
src/store/api/contentSources/onprem/tests/typeguards.test.ts#L73
Replace `·name:·'vim',·summary:·'Text·editor',·arch:·'x86_64',·release:·'1.el9'` with `⏎··········name:·'vim',⏎··········summary:·'Text·editor',⏎··········arch:·'x86_64',⏎··········release:·'1.el9',⏎·······`
|
|
ESLint:
src/store/api/contentSources/onprem/tests/typeguards.test.ts#L63
Replace `·name:·'vim',·summary:·'Text·editor',·version:·'8.2',·release:·'1.el9'` with `⏎··········name:·'vim',⏎··········summary:·'Text·editor',⏎··········version:·'8.2',⏎··········release:·'1.el9',⏎·······`
|
|
ESLint:
src/store/api/contentSources/onprem/tests/typeguards.test.ts#L43
Replace `·summary:·'No·name',·arch:·'x86_64',·version:·'8.2',·release:·'1.el9'` with `⏎··········summary:·'No·name',⏎··········arch:·'x86_64',⏎··········version:·'8.2',⏎··········release:·'1.el9',⏎·······`
|
|
Manual API Changes Check
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-node@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Circular Dependencies Check
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-node@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
ESLint
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-node@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
ESLint:
src/Components/CreateImageWizard/steps/Packages/components/Packages.tsx#L357
React Hook useEffect has missing dependencies: 'epelRepoUrlByDistribution', 'searchModulesInfo', and 'wizardMode'. Either include them or remove the dependency array
|
|
ESLint:
src/Components/CreateImageWizard/steps/Packages/components/Packages.tsx#L270
React Hook useEffect has missing dependencies: 'isOnPremise' and 'reposInTemplate'. Either include them or remove the dependency array
|
|
ESLint:
src/Components/CreateImageWizard/steps/Packages/components/PackageRecommendations.tsx#L128
React Hook useEffect has a missing dependency: 'distroRepoUrls'. Either include it or remove the dependency array
|
|
ESLint:
src/Components/CreateImageWizard/steps/Packages/components/PackageRecommendations.tsx#L115
React Hook useEffect has missing dependencies: 'analytics', 'distribution', 'isBeta', and 'isOnPremise'. Either include them or remove the dependency array
|
|
ESLint:
src/Components/CreateImageWizard/steps/Oscap/components/PolicySelector.tsx#L130
React Hook useEffect has missing dependencies: 'dispatch', 'policies', 'policyID', and 'policyTitle'. Either include them or remove the dependency array
|
|
ESLint:
src/Components/CreateImageWizard/steps/ImageOutput/index.tsx#L41
React Hook useEffect has a missing dependency: 'blueprintName'. Either include it or remove the dependency array
|
|
ESLint:
src/Components/CreateImageWizard/ImportImageWizard.tsx#L31
React Hook useEffect has missing dependencies: 'addNotification', 'navigate', and 'resolvePath'. Either include them or remove the dependency array
|
|
ESLint:
src/Components/CreateImageWizard/EditImageWizard.tsx#L43
React Hook useEffect has a missing dependency: 'resolvePath'. Either include it or remove the dependency array
|
|
ESLint:
src/Components/CreateImageWizard/CreateImageWizard.tsx#L338
React Hook useEffect has a missing dependency: 'timezone'. Either include it or remove the dependency array
|
|
ESLint:
src/Components/Blueprints/ImportBlueprintModal.tsx#L230
React Hook React.useEffect has missing dependencies: 'addNotification' and 'handleRepositoryImport'. Either include them or remove the dependency array
|
|
Build Check
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-node@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|