Skip to content

Commit 64c1c22

Browse files
committed
Wizard: Make aria-label different for groups and pkgs
1 parent 9cbf674 commit 64c1c22

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/Components/CreateImageWizard/steps/Packages/components/RemovePackageButton.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,13 @@ type RemovePackageButtonProps = {
1616
};
1717

1818
const RemovePackageButton = ({ item, onRemove }: RemovePackageButtonProps) => {
19+
const packageType = 'package_list' in item ? 'package group' : 'package';
20+
1921
return (
2022
<Button
2123
variant='plain'
2224
icon={<MinusCircleIcon />}
23-
aria-label='Remove package'
25+
aria-label={`Remove ${packageType}`}
2426
onClick={() => onRemove(item)}
2527
isInline
2628
hasNoPadding

src/test/Components/CreateImageWizard/steps/Packages/Packages.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -439,7 +439,7 @@ describe('Packages request generated correctly', () => {
439439
await selectFirstPkgOption('grouper'); // select
440440
await waitFor(async () =>
441441
user.click(
442-
await screen.findByRole('button', { name: /remove package/i }),
442+
await screen.findByRole('button', { name: /remove package group/i }),
443443
),
444444
);
445445
await goToReview();

0 commit comments

Comments
 (0)