Skip to content

Add widgetRegistry config to decouple widget layout from chrome#4259

Merged
regexowl merged 1 commit intoosbuild:mainfrom
tahmidefaz:widget-layout-migration
Apr 2, 2026
Merged

Add widgetRegistry config to decouple widget layout from chrome#4259
regexowl merged 1 commit intoosbuild:mainfrom
tahmidefaz:widget-layout-migration

Conversation

@tahmidefaz
Copy link
Copy Markdown
Contributor

@tahmidefaz tahmidefaz commented Mar 31, 2026 •
edited
Loading

Summary

  • Migrates the Image Builder widget layout configuration from chrome service to FEO by adding widgetRegistry to deploy/frontend-clowder.yml

Jira epic (decouple the widget layout dashboard from chrome service): https://redhat.atlassian.net/browse/RHCLOUD-40474

Widget Registry JSON (from chrome)

"imageBuilder": {
    "scope": "landing",
    "module": "./ImageBuilderWidget",
    "defaults": {
        "w": 1,
        "h": 4,
        "maxH": 10,
        "minH": 1
    },
    "config": {
        "title": "Image Builder",
        "icon": "RhelIcon",
        "headerLink": {}
    }
}

Note: headerLink: {} was omitted from the YAML config since the CRD schema requires both title and href when headerLink is present.

🤖 Generated with Claude Code

@tahmidefaz tahmidefaz requested a review from a team as a code owner March 31, 2026 19:00
sourcery-ai[bot]
sourcery-ai bot reviewed Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@regexowl
Copy link
Copy Markdown
Collaborator

regexowl commented Apr 2, 2026

Hey @tahmidefaz, thank you for the PR! Going through the epic, the code changes look good. Just to get more context - I assume we're talking about this widget on the consoleDot landing page, is that correct?

image

I believe the contents of the widget do not "live" in this repo yet. Would migrating that be a future step? Is there something more required on our side?

@regexowl
Copy link
Copy Markdown
Collaborator

regexowl commented Apr 2, 2026

/ok-to-test

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.52%. Comparing base (a40080d) to head (2d1f518).
⚠️ Report is 3 commits behind head on main.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4259   +/-   ##
=======================================
  Coverage   71.52%   71.52%           
=======================================
  Files         199      199           
  Lines        7526     7526           
  Branches     2813     2813           
=======================================
  Hits         5383     5383           
  Misses       1869     1869           
  Partials      274      274

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a40080d...2d1f518. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tahmidefaz
Copy link
Copy Markdown
Contributor Author

tahmidefaz commented Apr 2, 2026

Hey @tahmidefaz, thank you for the PR! Going through the epic, the code changes look good. Just to get more context - I assume we're talking about this widget on the consoleDot landing page, is that correct?

image I believe the contents of the widget do not "live" in this repo yet. Would migrating that be a future step? Is there something more required on our side?

@regexowl Thanks for the review. Yes, exactly! I will add your widget's source code to this repo under a subsequent PR - maybe sometime later today or tomorrow.

If there is anything required from our tenant's sides in the future, we will send you guys an email under the "Action Required" tag. 👍

@tahmidefaz @claude
Add widgetRegistry config to frontend-clowder.yml
2d1f518 
Migrate widget layout configuration from chrome service to FEO,
decoupling the Image Builder widget dashboard from chrome.

Ref: https://redhat.atlassian.net/browse/RHCLOUD-40474

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@tahmidefaz tahmidefaz force-pushed the widget-layout-migration branch from f919e83 to 2d1f518 Compare April 2, 2026 13:27
@regexowl
Copy link
Copy Markdown
Collaborator

regexowl commented Apr 2, 2026

/ok-to-test

@regexowl
Copy link
Copy Markdown
Collaborator

regexowl commented Apr 2, 2026

@regexowl Thanks for the review. Yes, exactly! I will add your widget's source code to this repo under a subsequent PR - maybe sometime later today or tomorrow.

If there is anything required from our tenant's sides in the future, we will send you guys an email under the "Action Required" tag. 👍

Sounds good, thank you!

@regexowl regexowl enabled auto-merge April 2, 2026 14:04
@regexowl regexowl added this pull request to the merge queue Apr 2, 2026
Merged via the queue into osbuild:main with commit 5257d0f Apr 2, 2026
24 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@regexowl regexowl regexowl approved these changes

@ksiekl ksiekl Awaiting requested review from ksiekl ksiekl is a code owner automatically assigned from osbuild/ib-service-reviewers

@tkoscieln tkoscieln Awaiting requested review from tkoscieln tkoscieln is a code owner automatically assigned from osbuild/ib-service-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tahmidefaz @regexowl