Skip to content

Commit 7b1e647

Browse files
mvo5supakeen
authored andcommitted
various: fix make gh-action-test and update README
We have the new `./test/scripts/install-dependencies` helper that centralizes the installation of the build dependencies. So use it in the Containerfile and update the README to point to it.
1 parent 2937921 commit 7b1e647

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

Containerfile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,7 @@ WORKDIR /setup
99
COPY ./test/scripts ./test/scripts/
1010
COPY Schutzfile .
1111
RUN ./test/scripts/setup-osbuild-repo
12-
13-
# NOTE: keep in sync with README.md#Contributing
14-
RUN dnf -y install krb5-devel go gpgme-devel osbuild-depsolve-dnf btrfs-progs-devel device-mapper-devel
12+
RUN ./test/scripts/install-dependencies
1513

1614
COPY go.mod go.sum .
1715
RUN go mod download

README.md

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,13 +48,21 @@ required.
4848

4949
#### Build requirements
5050

51-
The build-requirements of the Go library for Fedora and rpm-based distributions are:
51+
The build-requirements of the Go library for Fedora and rpm-based
52+
distributions can be installed with:
5253

53-
- `go`
54-
- `gpgme-devel`
54+
```console
55+
sudo ./test/scripts/install-dependencies
56+
```
5557

5658
(see also [`Containerfile`](Containerfile) )
5759

60+
The minimal dependencies are:
61+
62+
- `go`
63+
- `gpgme-devel`
64+
- `libvirt-devel`
65+
5866
Other dependencies only needed in some cases are:
5967

6068
- `btrfs-progs-devel`, `device-mapper-devel`

0 commit comments

Comments
 (0)