Fix fasterdata-tuning 1.3.10: ensure state operations return exit code 0 on success

Author: root

CHANGELOG.md

@@ -5,6 +5,12 @@
 
 All notable changes to this repository will be documented in this file.
 
+## [1.3.10] - 2026-01-27
+
+### Fixed
+
+- `fasterdata-tuning.sh` v1.3.10: Ensure all state management functions (`--restore-state`, `--diff-state`, `--list-states`) explicitly return 0 on successful completion so they exit with code 0 instead of inheriting non-zero exit codes from sub-commands.
+
 ## [1.3.9] - 2026-01-27
 
 ### Fixed

docs/perfsonar/tools_scripts/fasterdata-tuning.sh

@@ -1,7 +1,7 @@
 #!/usr/bin/env bash
 # fasterdata-tuning.sh
 # --------------------
-# Version: 1.3.9
+# Version: 1.3.10
 # Author: Shawn McKee, University of Michigan
 # Acknowledgements: Supported by IRIS-HEP and OSG-LHC
 #
@@ -26,6 +26,7 @@
 # NEW in v1.3.7: Fix summary display of packet pacing status to correctly detect applied qdisc.
 # NEW in v1.3.8: Validate required option arguments up front to avoid unbound-variable errors and provide clearer CLI feedback.
 # NEW in v1.3.9: Fix qdisc state restoration: properly reset interface qdisc to pfifo_fast when saved state lacks qdisc or has unknown qdisc (fixes packet pacing not being disabled after restore).
+# NEW in v1.3.10: Ensure all state management functions return 0 on successful completion so --restore-state/--diff-state/--list-states exit cleanly with code 0.
 #
 # Sources: https://fasterdata.es.net/host-tuning/ , /network-tuning/ , /DTN/
 #
@@ -2432,6 +2433,7 @@ do_list_states() {
   done <<< "$states"
 
   echo ""
+  return 0
 }
 
 do_delete_state() {
@@ -2573,6 +2575,7 @@ PY
   echo ""
   echo "Use --restore-state to restore the saved configuration"
   echo ""
+  return 0
 }
 
 do_restore_state() {
@@ -2890,6 +2893,7 @@ PY
   echo "Note: Some settings may require a reboot to take full effect."
   echo "Run with --mode audit to verify the restored state."
   echo ""
+  return 0
 }
 
 print_host_info() {

docs/perfsonar/tools_scripts/fasterdata-tuning.sh.sha256

@@ -1 +1 @@
-8c47574d2dc228cb65affe6330eb2dede21ae31f3ec8e3a0eb0c1e2ae57db5e0  fasterdata-tuning.sh
+dfbdd6abe4f99a9196376de16d92648a0327d1667ddbb1d5d4a354f04e33ce8f  fasterdata-tuning.sh

docs/perfsonar/tools_scripts/scripts.sha256

@@ -1,8 +1,8 @@
 166d52478315bf67e63e69e3c9272734434f6ad2a3fa30b30b37c80c94d97034  certbot-deploy-hook.sh
 2812b78534e8268751250b271cf0ac1868a6a8b420f9e6b4f96f715459d0eaf5  check-deps.sh
 f0bf15b7223447878b00260d33f1db41995f47d4b56216911bbabe7f1b8435a9  check-perfsonar-dns.sh
-d1f100e2e5eba58007bf89455edb1b7065e8e7124c9a4238f18ce13c60a2f2e5  configure-toolkit-letsencrypt.sh
-8c47574d2dc228cb65affe6330eb2dede21ae31f3ec8e3a0eb0c1e2ae57db5e0  fasterdata-tuning.sh
+8c47574d2dc228cb65affe6330eb2dede21ae31f3ec8e3a0eb0c1e2ae57db5e0  configure-toolkit-letsencrypt.sh
+dfbdd6abe4f99a9196376de16d92648a0327d1667ddbb1d5d4a354f04e33ce8f  fasterdata-tuning.sh
 14d88a50bcbc606b21b00b4bcfab779c2a2f70f1576593f66502611719620df0  install-systemd-service.sh
 4b2b91593a3ceb3c8159cc2d6ca749aeeb7a558a766227c46493feb84655f04a  install-systemd-units.sh
 9d9ff6bab281c800c923ac9616c9f88502e9677d6902d3df243fa5faf50a02fe  install_tools_scripts.sh