Bump fasterdata-tuning to 1.3.8

Author: root

CHANGELOG.md

@@ -5,6 +5,12 @@
 
 All notable changes to this repository will be documented in this file.
 
+## [1.3.8] - 2026-01-26
+
+### Fixed
+
+- `fasterdata-tuning.sh` v1.3.8: Guard all flags that require a value so missing arguments fail fast with a helpful error instead of triggering `set -u` unbound variable crashes (e.g., `--restore-state`).
+
 ## [1.3.7] - 2025-12-19
 
 ### Fixed

docs/perfsonar/tools_scripts/fasterdata-tuning.sh

@@ -1,7 +1,7 @@
 #!/usr/bin/env bash
 # fasterdata-tuning.sh
 # --------------------
-# Version: 1.3.7
+# Version: 1.3.8
 # Author: Shawn McKee, University of Michigan
 # Acknowledgements: Supported by IRIS-HEP and OSG-LHC
 #
@@ -24,6 +24,7 @@
 #                --diff-state/--restore-state can parse saved files reliably.
 # NEW in v1.3.6: Respect --dry-run for packet pacing; audit checks actual qdisc.
 # NEW in v1.3.7: Fix summary display of packet pacing status to correctly detect applied qdisc.
+# NEW in v1.3.8: Validate required option arguments up front to avoid unbound-variable errors and provide clearer CLI feedback.
 #
 # Sources: https://fasterdata.es.net/host-tuning/ , /network-tuning/ , /DTN/
 #
@@ -129,6 +130,17 @@ State Management Options:
 EOF
 }
 
+# Ensure required option arguments are present; fail fast with a helpful message
+require_arg() {
+  local flag="$1"
+  local val="${2-}"
+  if [[ -z "$val" || "$val" == -* ]]; then
+    echo "ERROR: $flag requires an argument" >&2
+    usage
+    exit 1
+  fi
+}
+
 # Speed-specific tuning recommendations from ESnet fasterdata.es.net
 # Values indexed by link speed in Mbps: [rmem_max, wmem_max, tcp_rmem_max, tcp_wmem_max, netdev_max_backlog]
 # For measurement hosts (perfSONAR): optimized for moderate RTT (50-100ms) paths
@@ -3184,30 +3196,30 @@ print_summary() {
 main() {
   while [[ $# -gt 0 ]]; do
     case "$1" in
-      --mode) MODE="$2"; shift 2;;
-      --ifaces) IFACES="$2"; shift 2;;
-      --target) TARGET_TYPE="$2"; shift 2;;
-      --tbf-cap-rate) TBF_CAP_RATE="$2"; USE_TBF_CAP=1; shift 2;;
-      --packet-pacing-rate) TBF_CAP_RATE="$2"; USE_TBF_CAP=1; log_warn "--packet-pacing-rate is deprecated; use --tbf-cap-rate"; shift 2;;
+      --mode) require_arg "$1" "${2-}"; MODE="$2"; shift 2;;
+      --ifaces) require_arg "$1" "${2-}"; IFACES="$2"; shift 2;;
+      --target) require_arg "$1" "${2-}"; TARGET_TYPE="$2"; shift 2;;
+      --tbf-cap-rate) require_arg "$1" "${2-}"; TBF_CAP_RATE="$2"; USE_TBF_CAP=1; shift 2;;
+      --packet-pacing-rate) require_arg "$1" "${2-}"; TBF_CAP_RATE="$2"; USE_TBF_CAP=1; log_warn "--packet-pacing-rate is deprecated; use --tbf-cap-rate"; shift 2;;
       --apply-packet-pacing) APPLY_PACKET_PACING=1; shift;;
       --use-tbf-cap) USE_TBF_CAP=1; shift;;
       --color) USE_COLOR=1; shift;;
       --nocolor) USE_COLOR=0; shift;;
         --apply-iommu) APPLY_IOMMU=1; shift;;
-        --iommu-args) IOMMU_ARGS="$2"; shift 2;;
-      --apply-smt) APPLY_SMT="$2"; shift 2;;
+        --iommu-args) require_arg "$1" "${2-}"; IOMMU_ARGS="$2"; shift 2;;
+      --apply-smt) require_arg "$1" "${2-}"; APPLY_SMT="$2"; shift 2;;
       --persist-smt) PERSIST_SMT=1; shift;;
-      --apply-tcp-cc) APPLY_TCP_CC="$2"; shift 2;;
+      --apply-tcp-cc) require_arg "$1" "${2-}"; APPLY_TCP_CC="$2"; shift 2;;
       --apply-jumbo) APPLY_JUMBO=1; shift;;
       --yes) AUTO_YES=1; shift;;
       --dry-run) DRY_RUN=1; shift;;
           --json) OUTPUT_JSON=1; shift;;
       --save-state) SAVE_STATE=1; shift;;
-      --label) STATE_LABEL="$2"; shift 2;;
-      --restore-state) RESTORE_STATE="$2"; shift 2;;
+      --label) require_arg "$1" "${2-}"; STATE_LABEL="$2"; shift 2;;
+      --restore-state) require_arg "$1" "${2-}"; RESTORE_STATE="$2"; shift 2;;
       --list-states) LIST_STATES=1; shift;;
-      --diff-state) DIFF_STATE="$2"; shift 2;;
-      --delete-state) DELETE_STATE="$2"; shift 2;;
+      --diff-state) require_arg "$1" "${2-}"; DIFF_STATE="$2"; shift 2;;
+      --delete-state) require_arg "$1" "${2-}"; DELETE_STATE="$2"; shift 2;;
       --auto-save-before) AUTO_SAVE_BEFORE=1; shift;;
       -h|--help) usage; exit 0;;
       -v|--version) echo "fasterdata-tuning.sh v$(get_script_version)"; exit 0;;

docs/perfsonar/tools_scripts/fasterdata-tuning.sh.sha256

@@ -1 +1 @@
-5ac597d118a4d341b1b8107df884d2ed6a3f52e851123606e05ef1f841dec85c  fasterdata-tuning.sh
+d01e94fd59b7198f6d755c5dc94e480b00ebd59f7069e20cc12ee5b1a91d24f0  fasterdata-tuning.sh

docs/perfsonar/tools_scripts/scripts.sha256

@@ -2,7 +2,7 @@
 2812b78534e8268751250b271cf0ac1868a6a8b420f9e6b4f96f715459d0eaf5  check-deps.sh
 f0bf15b7223447878b00260d33f1db41995f47d4b56216911bbabe7f1b8435a9  check-perfsonar-dns.sh
 d1f100e2e5eba58007bf89455edb1b7065e8e7124c9a4238f18ce13c60a2f2e5  configure-toolkit-letsencrypt.sh
-f8cee9f11e57d06a0239186d9371e4f520b1cc6bb20527e6d58cc31d6af1316b  fasterdata-tuning.sh
+d01e94fd59b7198f6d755c5dc94e480b00ebd59f7069e20cc12ee5b1a91d24f0  fasterdata-tuning.sh
 14d88a50bcbc606b21b00b4bcfab779c2a2f70f1576593f66502611719620df0  install-systemd-service.sh
 4b2b91593a3ceb3c8159cc2d6ca749aeeb7a558a766227c46493feb84655f04a  install-systemd-units.sh
 9d9ff6bab281c800c923ac9616c9f88502e9677d6902d3df243fa5faf50a02fe  install_tools_scripts.sh