Skip to content

Commit 41d15f8

Browse files
committed
Merge branch 'hotfix-1.0.3' into stable
2 parents e0831a3 + ea178d3 commit 41d15f8

File tree

6 files changed

+14
-9
lines changed

6 files changed

+14
-9
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# Changelog
22

3+
## 1.0.3
4+
- Use light-baseimage:0.1.2
5+
- Fixes :
6+
- Re-running container with volumes won't start #19
7+
38
## 1.0.2
49

510
- Add TLS environment variable :

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
NAME = osixia/openldap
2-
VERSION = 1.0.2
2+
VERSION = 1.0.3
33

44
.PHONY: all build test tag_latest release
55

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ A simple solution to backup your ldap server, our openldap-backup docker image :
156156
157157
## Environment Variables
158158

159-
Environement variables defaults are set in **image/env.yaml**. You can modify environment variable values directly in this file and rebuild the image ([see manual build](#manual-build)). You can also override those values at run time with -e argument or by setting your own env.yaml file as a docker volume to `/etc/env.yaml`. See examples below.
159+
Environement variables defaults are set in **image/env.yaml**. You can modify environment variable values directly in this file and rebuild the image ([see manual build](#manual-build)). You can also override those values at run time with -e argument or by setting your own env.yaml file as a docker volume to `/container/environment/env.yaml`. See examples below.
160160

161161
General container configuration :
162162
- **LDAP_LOG_LEVEL**: Slap log level. defaults to `256`. See table 5.1 in http://www.openldap.org/doc/admin24/slapdconf2.html for the available log levels.
@@ -199,9 +199,9 @@ Environment variable can be set directly by adding the -e argument in the comman
199199
docker run -e LDAP_ORGANISATION="My Compagny" -e LDAP_DOMAIN="my-compagny.com" \
200200
-e LDAP_ADMIN_PASSWORD="JonSn0w" -d osixia/openldap
201201

202-
Or by setting your own `env.yaml` file as a docker volume to `/etc/env.yaml`
202+
Or by setting your own `env.yaml` file as a docker volume to `/container/environment/env.yaml`
203203

204-
docker run -v /data/my-env.yaml:/etc/env.yaml \
204+
docker run -v /data/my-env.yaml:/container/environment/env.yaml \
205205
-d osixia/openldap
206206

207207
## Manual build

image/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM osixia/light-baseimage:0.1.1
1+
FROM osixia/light-baseimage:0.1.2
22
MAINTAINER Bertrand Gouny <[email protected]>
33

44
# Use baseimage's init system.
@@ -26,7 +26,7 @@ RUN /container/tool/install-service \
2626
&& rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*
2727

2828
# Add default env variables
29-
ADD env.yaml /etc/env.yaml
29+
ADD env.yaml /container/environment/env.yaml
3030

3131
# Set OpenLDAP data and config directories in a data volume
3232
VOLUME ["/var/lib/ldap", "/etc/ldap/slapd.d"]

image/env.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ LDAP_REPLICATION: false
3030
# if you want to add replication to an existing ldap
3131
# adapt LDAP_REPLICATION_CONFIG_SYNCPROV and LDAP_REPLICATION_HDB_SYNCPROV to your configuration
3232
# avoid using $LDAP_BASE_DN, $LDAP_ADMIN_PASSWORD and $LDAP_CONFIG_PASSWORD variables
33-
LDAP_REPLICATION_CONFIG_SYNCPROV: binddn="cn=admin,cn=config" bindmethod=simple credentials=$LDAP_CONFIG_PASSWORD searchbase="cn=config" type=refreshAndPersist retry="5 5 300 5" timeout=1 starttls=critical
34-
LDAP_REPLICATION_HDB_SYNCPROV: binddn="cn=admin,$LDAP_BASE_DN" bindmethod=simple credentials=$LDAP_ADMIN_PASSWORD searchbase="$LDAP_BASE_DN" type=refreshAndPersist interval=00:00:00:10 retry="5 5 300 5" timeout=1 starttls=critical
33+
LDAP_REPLICATION_CONFIG_SYNCPROV: binddn="cn=admin,cn=config" bindmethod=simple credentials=$LDAP_CONFIG_PASSWORD searchbase="cn=config" type=refreshAndPersist retry="60 +" timeout=1 starttls=critical
34+
LDAP_REPLICATION_HDB_SYNCPROV: binddn="cn=admin,$LDAP_BASE_DN" bindmethod=simple credentials=$LDAP_ADMIN_PASSWORD searchbase="$LDAP_BASE_DN" type=refreshAndPersist interval=00:00:00:10 retry="60 +" timeout=1 starttls=critical
3535
LDAP_REPLICATION_HOSTS:
3636
- ldap://ldap.example.org # The order must be the same on all ldap servers
3737
- ldap://ldap2.example.org

image/service/slapd/container-start.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ EOF
104104

105105
# start OpenLDAP
106106
echo "Starting openldap..."
107-
slapd -h "ldap://localhost ldapi:///" -u openldap -g openldap
107+
slapd -h "ldap://$HOSTNAME ldap://localhost ldapi:///" -u openldap -g openldap
108108
echo "[ok]"
109109

110110
# set bootstrap config part 2

0 commit comments

Comments
 (0)