Skip to content

Commit 0c3ea69

Browse files
committed
Fix binary downloads
1 parent d5e3fb3 commit 0c3ea69

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
## ?.?.? - Unreleased
22

3+
* Fixed binary file downloads.
34
* Fixed credentials cache handling.
45

56
## 3.3.0 - 2025-06-20

okdata/sdk/data/download.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ def download(self, dataset_id, version, edition, output_path, retries=0):
2828
downloaded_files = []
2929
for file in self.get_files(dataset_id, version, edition, retries=retries):
3030
file_name = file["key"].split("/")[-1]
31-
file_content_response = requests.get(file["url"])
31+
file_content_response = requests.get(file["url"], stream=True)
3232
file_content_response.raise_for_status()
3333

34-
write_file_content(file_name, output_path, file_content_response.text)
34+
write_file_content(file_name, output_path, file_content_response.raw.read())
3535
downloaded_files.append(f"{output_path}/{file_name}")
3636

3737
return {"files": downloaded_files}

okdata/sdk/io_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,5 +42,5 @@ def write_file_content(file_name, path, content):
4242
if not Path(path).exists():
4343
create_dir(path)
4444

45-
with open(f"{path}/{file_name}", "w+") as file:
45+
with open(f"{path}/{file_name}", "wb") as file:
4646
file.write(content)

0 commit comments

Comments
 (0)