Skip to content

Commit af56062

Browse files
authored
Merge pull request #99 from oslokommune/262-team-by-name
T#262 Add `TeamClient.get_team_by_name`
2 parents 2ed3c60 + 1971928 commit af56062

File tree

3 files changed

+19
-0
lines changed

3 files changed

+19
-0
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
## ?.?.?
22

3+
* New method `TeamClient.get_team_by_name`.
34
* Fixed a deprecation warning from urllib3.
45

56
## 2.0.0

okdata/sdk/team/client.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,3 +31,9 @@ def get_team(self, team_id):
3131
url = "{}/teams/{}".format(self.api_url, quote(team_id))
3232
log.info(f"SDK:Getting team from: {url}")
3333
return self.get(url).json()
34+
35+
def get_team_by_name(self, team_name):
36+
"""Return details for a team by name."""
37+
url = "{}/teams/name/{}".format(self.api_url, quote(team_name))
38+
log.info(f"SDK:Getting team from: {url}")
39+
return self.get(url).json()

tests/team/test_client.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,3 +25,15 @@ def test_get_team(requests_mock):
2525
status_code=200,
2626
)
2727
assert TeamClient().get_team(team_id) == team
28+
29+
30+
def test_get_team_by_name(requests_mock):
31+
team_name = "Foo"
32+
team = {"team_id": "abc", "name": team_name}
33+
requests_mock.register_uri(
34+
"GET",
35+
re.compile(f"teams/name/{team_name}"),
36+
text=json.dumps(team),
37+
status_code=200,
38+
)
39+
assert TeamClient().get_team_by_name(team_name) == team

0 commit comments

Comments
 (0)