Add versions of params_t::set() function and add some tests

It seems superfluous to have all these implementations of the set()
function, but there are some problems with MSVC 2019, and this is the
workaround. See https://developercommunity.visualstudio.com/t/10242620

Author: joto

src/params.hpp

@@ -33,10 +33,43 @@ std::string to_string(param_value_t const &value);
 class params_t
 {
 public:
-    template <typename K, typename V>
+    // It seems superfluous to have all these implementations of the set()
+    // function, but there are some problems with MSVC 2019, and this is the
+    // workaround. See https://developercommunity.visualstudio.com/t/10242620
+    template <typename K>
+    void set(K &&key, bool value)
+    {
+        m_map.insert_or_assign(std::forward<K>(key), value);
+    }
+
+    template <typename K>
+    void set(K &&key, double value)
+    {
+        m_map.insert_or_assign(std::forward<K>(key), value);
+    }
+
+    template <typename K>
+    void set(K &&key, float value)
+    {
+        m_map.insert_or_assign(std::forward<K>(key), value);
+    }
+
+    template <typename K, typename V,
+              std::enable_if_t<std::is_integral_v<std::remove_reference_t<V>>,
+                               bool> = true>
+    void set(K &&key, V value)
+    {
+        m_map.insert_or_assign(std::forward<K>(key),
+                               static_cast<int64_t>(value));
+    }
+
+    template <
+        typename K, typename V,
+        std::enable_if_t<!std::is_arithmetic_v<std::remove_reference_t<V>>,
+                         bool> = true>
     void set(K &&key, V &&value)
     {
-        m_map.insert_or_assign(std::forward<K>(key), std::forward<V>(value));
+        m_map.insert_or_assign(std::forward<K>(key), std::string(value));
     }
 
     template <typename K>

tests/CMakeLists.txt

@@ -86,6 +86,7 @@ set_test(test-output-pgsql-style-file)
 set_test(test-output-pgsql-tablespace LABELS Tablespace)
 set_test(test-output-pgsql-validgeom)
 set_test(test-output-pgsql-z_order)
+set_test(test-params LABELS NoDB)
 set_test(test-persistent-cache LABELS NoDB)
 set_test(test-pgsql)
 set_test(test-pgsql-capabilities)

tests/test-params.cpp

@@ -0,0 +1,65 @@
+/**
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ *
+ * This file is part of osm2pgsql (https://osm2pgsql.org/).
+ *
+ * Copyright (C) 2006-2024 by the osm2pgsql developer community.
+ * For a full list of authors see the git log.
+ */
+
+#include <catch.hpp>
+
+#include "params.hpp"
+
+TEST_CASE("Set param value", "[NoDB]")
+{
+    param_value_t const p_null{null_param_t()};
+    param_value_t const p_str{std::string{"foo"}};
+    param_value_t const p_int{static_cast<int64_t>(26)};
+    param_value_t const p_double{3.141};
+    param_value_t const p_true{true};
+    param_value_t const p_false{false};
+
+    REQUIRE(to_string(p_null).empty());
+    REQUIRE(to_string(p_str) == "foo");
+    REQUIRE(to_string(p_int) == "26");
+    REQUIRE(to_string(p_double) == "3.141");
+    REQUIRE(to_string(p_true) == "true");
+    REQUIRE(to_string(p_false) == "false");
+}
+
+TEST_CASE("Params with different value types", "[NoDB]")
+{
+    params_t params;
+    REQUIRE_FALSE(params.has("foo"));
+
+    params.set("foo", 99);
+    REQUIRE(params.has("foo"));
+    REQUIRE(params.get("foo") == param_value_t(static_cast<int64_t>(99)));
+    REQUIRE(params.get_int64("foo") == 99);
+
+    params.set("foo", "astring");
+    REQUIRE(params.has("foo"));
+    REQUIRE(params.get("foo") == param_value_t(std::string("astring")));
+    REQUIRE(params.get_string("foo") == "astring");
+    REQUIRE_THROWS(params.get_int64("foo"));
+}
+
+TEST_CASE("Set params with explicit type", "[NoDB]")
+{
+    params_t params;
+
+    params.set("isstring", "hi");
+    params.set("isint", 567);
+    params.set("isdouble", 567.0);
+    params.set("istrue", true);
+    params.set("isfalse", false);
+
+    REQUIRE(params.get_string("isstring") == "hi");
+    REQUIRE(params.get_int64("isint") == 567);
+    REQUIRE(params.get_double("isdouble") == Approx(567.0));
+    REQUIRE(params.get_bool("istrue"));
+    REQUIRE_FALSE(params.get_bool("isfalse"));
+
+    REQUIRE_THROWS(params.get("does not exist"));
+}