Change function parameter from int to bool

We are not using it for anything else anyway.

Author: joto

src/osmdata.cpp

@@ -171,7 +171,7 @@ struct pending_threaded_processor : public middle_t::pending_processor
     using output_vec_t = std::vector<std::shared_ptr<output_t>>;
 
     static void do_jobs(output_vec_t const &outputs, pending_queue_t &queue,
-                        size_t &ids_done, std::mutex &mutex, int append,
+                        size_t &ids_done, std::mutex &mutex, bool append,
                         bool ways)
     {
         while (true) {

src/output-flex.cpp

@@ -1007,7 +1007,7 @@ void output_flex_t::call_process_function(int index,
     }
 }
 
-void output_flex_t::pending_way(osmid_t id, int exists)
+void output_flex_t::pending_way(osmid_t id, bool exists)
 {
     if (!m_has_process_way) {
         return;
@@ -1031,7 +1031,7 @@ void output_flex_t::pending_way(osmid_t id, int exists)
     m_buffer.clear();
 }
 
-void output_flex_t::pending_relation(osmid_t id, int exists)
+void output_flex_t::pending_relation(osmid_t id, bool exists)
 {
     if (!m_has_process_relation) {
         return;

src/output-flex.hpp

@@ -61,8 +61,8 @@ class output_flex_t : public output_t
 
     void stage2_proc() override;
 
-    void pending_way(osmid_t id, int exists) override;
-    void pending_relation(osmid_t id, int exists) override;
+    void pending_way(osmid_t id, bool exists) override;
+    void pending_relation(osmid_t id, bool exists) override;
 
     void node_add(osmium::Node const &node) override;
     void way_add(osmium::Way *way) override;

src/output-gazetteer.hpp

@@ -48,8 +48,8 @@ class output_gazetteer_t : public output_t
 
     bool need_forward_dependencies() const noexcept override { return false; }
 
-    void pending_way(osmid_t, int) override {}
-    void pending_relation(osmid_t, int) override {}
+    void pending_way(osmid_t, bool) override {}
+    void pending_relation(osmid_t, bool) override {}
 
     void node_add(osmium::Node const &node) override;
     void way_add(osmium::Way *way) override;

src/output-multi.cpp

@@ -65,7 +65,7 @@ void output_multi_t::start()
                    m_options.tblsmain_data);
 }
 
-void output_multi_t::pending_way(osmid_t id, int exists)
+void output_multi_t::pending_way(osmid_t id, bool exists)
 {
     // Try to fetch the way from the DB
     buffer.clear();
@@ -75,7 +75,7 @@ void output_multi_t::pending_way(osmid_t id, int exists)
     }
 }
 
-void output_multi_t::pending_relation(osmid_t id, int exists)
+void output_multi_t::pending_relation(osmid_t id, bool exists)
 {
     // Try to fetch the relation from the DB
     buffer.clear();

src/output-multi.hpp

@@ -46,8 +46,8 @@ class output_multi_t : public output_t
     void stop(osmium::thread::Pool *pool) override;
     void commit() override;
 
-    void pending_way(osmid_t id, int exists) override;
-    void pending_relation(osmid_t id, int exists) override;
+    void pending_way(osmid_t id, bool exists) override;
+    void pending_relation(osmid_t id, bool exists) override;
 
     void node_add(osmium::Node const &node) override;
     void way_add(osmium::Way *way) override;

src/output-null.hpp

@@ -24,8 +24,8 @@ class output_null_t : public output_t
 
     bool need_forward_dependencies() const noexcept override { return false; }
 
-    void pending_way(osmid_t /*id*/, int /*exists*/) override {}
-    void pending_relation(osmid_t /*id*/, int /*exists*/) override {}
+    void pending_way(osmid_t /*id*/, bool /*exists*/) override {}
+    void pending_relation(osmid_t /*id*/, bool /*exists*/) override {}
 
     void node_add(osmium::Node const & /*node*/) override {}
     void way_add(osmium::Way * /*way*/) override {}

src/output-pgsql.cpp

@@ -66,7 +66,7 @@ void output_pgsql_t::pgsql_out_way(osmium::Way const &way, taglist_t *tags,
     }
 }
 
-void output_pgsql_t::pending_way(osmid_t id, int exists)
+void output_pgsql_t::pending_way(osmid_t id, bool exists)
 {
     // Try to fetch the way from the DB
     buffer.clear();
@@ -90,7 +90,7 @@ void output_pgsql_t::pending_way(osmid_t id, int exists)
     }
 }
 
-void output_pgsql_t::pending_relation(osmid_t id, int exists)
+void output_pgsql_t::pending_relation(osmid_t id, bool exists)
 {
     // Try to fetch the relation from the DB
     // Note that we cannot use the global buffer here because

src/output-pgsql.hpp

@@ -46,8 +46,8 @@ class output_pgsql_t : public output_t
     void stop(osmium::thread::Pool *pool) override;
     void commit() override;
 
-    void pending_way(osmid_t id, int exists) override;
-    void pending_relation(osmid_t id, int exists) override;
+    void pending_way(osmid_t id, bool exists) override;
+    void pending_relation(osmid_t id, bool exists) override;
 
     void node_add(osmium::Node const &node) override;
     void way_add(osmium::Way *way) override;

src/output.hpp

@@ -55,8 +55,8 @@ class output_t
 
     virtual bool need_forward_dependencies() const noexcept { return true; }
 
-    virtual void pending_way(osmid_t id, int exists) = 0;
-    virtual void pending_relation(osmid_t id, int exists) = 0;
+    virtual void pending_way(osmid_t id, bool exists) = 0;
+    virtual void pending_relation(osmid_t id, bool exists) = 0;
 
     virtual void node_add(osmium::Node const &node) = 0;
     virtual void way_add(osmium::Way *way) = 0;