Suppress various false-positive clang-tidy warnings

Author: joto

src/expire-tiles.cpp

@@ -135,6 +135,8 @@ void expire_tiles::from_geometry(geom::multipolygon_t const &geom,
     }
 }
 
+// False positive: Apparently clang-tidy can not see through the visit()
+// NOLINTNEXTLINE(readability-convert-member-functions-to-static)
 void expire_tiles::from_geometry(geom::geometry_t const &geom,
                                  expire_config_t const &expire_config)
 {

src/geom-functions.cpp

@@ -437,6 +437,8 @@ class split_visitor
     void operator()(T) const
     {}
 
+    // false positive https://github.com/llvm/llvm-project/issues/74738
+    // NOLINTNEXTLINE(cppcoreguidelines-rvalue-reference-param-not-moved)
     void operator()(geom::collection_t &&geom) const
     {
         for (auto &&sgeom : geom) {
@@ -445,6 +447,8 @@ class split_visitor
     }
 
     template <typename T>
+    // false positive https://github.com/llvm/llvm-project/issues/74738
+    // NOLINTNEXTLINE(cppcoreguidelines-rvalue-reference-param-not-moved)
     void operator()(geom::multigeometry_t<T> &&geom) const
     {
         for (auto &&sgeom : geom) {

src/thread-pool.hpp

@@ -95,6 +95,7 @@ class thread_pool_t
      *         of the task can be queried.
      */
     template <typename TFunction>
+    // NOLINTNEXTLINE(cppcoreguidelines-missing-std-forward) false positive
     std::future<std::chrono::microseconds> submit(TFunction &&func)
     {
         std::packaged_task<std::chrono::microseconds()> task{