Fix signed to unsigned conversion

joto · joto · commit 7c01de8341f4 · 2022-11-19T15:48:04.000+01:00
STR34-C https://wiki.sei.cmu.edu/confluence/pages/viewpage.action?pageId=87158805
diff --git a/src/db-copy-mgr.hpp b/src/db-copy-mgr.hpp
@@ -258,7 +258,7 @@ class db_copy_mgr_t
         char const *const lookup_hex = "0123456789ABCDEF";
 
         for (auto c : wkb) {
-            auto const num = static_cast<unsigned int>(c);
+            unsigned int const num = static_cast<unsigned char>(c);
             m_current->buffer += lookup_hex[(num >> 4U) & 0xfU];
             m_current->buffer += lookup_hex[num & 0xfU];
         }

Original file line number	Diff line number	Diff line change
`@@ -258,7 +258,7 @@ class db_copy_mgr_t`
`258`	`258`	`char const *const lookup_hex = "0123456789ABCDEF";`
`259`	`259`
`260`	`260`	`for (auto c : wkb) {`
`261`		`- auto const num = static_cast<unsigned int>(c);`
	`261`	`+ unsigned int const num = static_cast<unsigned char>(c);`
`262`	`262`	`m_current->buffer += lookup_hex[(num >> 4U) & 0xfU];`
`263`	`263`	`m_current->buffer += lookup_hex[num & 0xfU];`
`264`	`264`	`}`