Refactor output_tiles_to_file() function

* Use consistent parameter names in hpp and cpp files
* Use string_view for file name
* Put file name at the end of the parameter list (for consistency
  with future output_tiles_to_*() functions with similar parameter
  lists)

Author: joto

src/expire-tiles.cpp

@@ -264,20 +264,20 @@ void expire_tiles::merge_and_destroy(expire_tiles *other)
     }
 }
 
-std::size_t output_tiles_to_file(quadkey_list_t const &tiles_maxzoom,
-                                 char const *filename, uint32_t minzoom,
-                                 uint32_t maxzoom)
+std::size_t output_tiles_to_file(quadkey_list_t const &tiles_at_maxzoom,
+                                 uint32_t minzoom, uint32_t maxzoom,
+                                 std::string_view filename)
 {
-    FILE *outfile = std::fopen(filename, "a");
+    FILE *outfile = std::fopen(filename.data(), "a");
     if (outfile == nullptr) {
         log_warn("Failed to open expired tiles file ({}).  Tile expiry "
                  "list will not be written!",
                  std::strerror(errno));
         return 0;
     }
 
-    auto const count =
-        for_each_tile(tiles_maxzoom, minzoom, maxzoom, [&](tile_t const &tile) {
+    auto const count = for_each_tile(
+        tiles_at_maxzoom, minzoom, maxzoom, [&](tile_t const &tile) {
             fmt::print(outfile, "{}/{}/{}\n", tile.zoom(), tile.x(), tile.y());
         });
 

src/expire-tiles.hpp

@@ -11,6 +11,7 @@
  */
 
 #include <memory>
+#include <string_view>
 #include <unordered_set>
 #include <utility>
 #include <vector>
@@ -164,13 +165,13 @@ std::size_t for_each_tile(quadkey_list_t const &tiles, uint32_t minzoom,
 /**
  * Write the list of tiles to a file.
  *
- * \param tiles The list of tiles at maximum zoom level
- * \param filename Name of the file
+ * \param tiles_at_maxzoom The list of tiles at maximum zoom level
  * \param minzoom Minimum zoom level
  * \param maxzoom Maximum zoom level
+ * \param filename Name of the file
  */
-std::size_t output_tiles_to_file(quadkey_list_t const &tiles,
-                                 char const *filename, uint32_t minzoom,
-                                 uint32_t maxzoom);
+std::size_t output_tiles_to_file(quadkey_list_t const &tiles_at_maxzoom,
+                                 uint32_t minzoom, uint32_t maxzoom,
+                                 std::string_view filename);
 
 #endif // OSM2PGSQL_EXPIRE_TILES_HPP

src/output-flex.cpp

@@ -1274,9 +1274,9 @@ void output_flex_t::stop()
 
     if (get_options()->expire_tiles_zoom_min > 0) {
         auto const count = output_tiles_to_file(
-            m_expire.get_tiles(), get_options()->expire_tiles_filename.c_str(),
-            get_options()->expire_tiles_zoom_min,
-            get_options()->expire_tiles_zoom);
+            m_expire.get_tiles(), get_options()->expire_tiles_zoom_min,
+            get_options()->expire_tiles_zoom,
+            get_options()->expire_tiles_filename);
         log_info("Wrote {} entries to expired tiles list", count);
     }
 }

src/output-pgsql.cpp

@@ -147,9 +147,9 @@ void output_pgsql_t::stop()
 
     if (get_options()->expire_tiles_zoom_min > 0) {
         auto const count = output_tiles_to_file(
-            m_expire.get_tiles(), get_options()->expire_tiles_filename.c_str(),
-            get_options()->expire_tiles_zoom_min,
-            get_options()->expire_tiles_zoom);
+            m_expire.get_tiles(), get_options()->expire_tiles_zoom_min,
+            get_options()->expire_tiles_zoom,
+            get_options()->expire_tiles_filename);
         log_info("Wrote {} entries to expired tiles list", count);
     }
 }