Merge pull request #2401 from joto/clang-tidy-fix

Fiddling with clang-tidy

Author: lonvia

.clang-tidy

@@ -88,7 +88,7 @@ Checks: '*,-abseil-*,-altera-*,-android-cloexec-*,-boost-use-ranges,-bugprone-ch
 #    Readability is a matter of opinion here
 #
 #WarningsAsErrors: '*'
-HeaderFilterRegex: '\/src\/'
+HeaderFilterRegex: '\/(src|tests)\/'
 CheckOptions:
     - key: cppcoreguidelines-special-member-functions.AllowSoleDefaultDtor
       value: true

CMakeLists.txt

@@ -286,6 +286,7 @@ if (CLANG_TIDY)
 
     add_custom_target(clang-tidy
         ${CLANG_TIDY}
+        --config-file ${CMAKE_SOURCE_DIR}/.clang-tidy
         -p ${CMAKE_BINARY_DIR}
         ${CT_CHECK_FILES}
     )

tests/common-cleanup.hpp

@@ -34,6 +34,12 @@ class file_t
         }
     }
 
+    file_t(file_t const &) = delete;
+    file_t &operator=(file_t const &) = delete;
+
+    file_t(file_t &&) = delete;
+    file_t &operator=(file_t const &&) = delete;
+
     ~file_t() noexcept { delete_file(true); }
 
 private:

tests/common-pg.hpp

@@ -132,6 +132,9 @@ class tempdb_t
     tempdb_t(tempdb_t &&) = delete;
     tempdb_t &operator=(tempdb_t const &&) = delete;
 
+    // We want to terminate the program if there is an exception thrown inside
+    // the destructor.
+    // NOLINTNEXTLINE(bugprone-exception-escape)
     ~tempdb_t() noexcept
     {
         if (m_db_name.empty()) {