Remove unnecessary conversion of id to string

joto · joto · commit eb63366728d2 · 2023-01-15T09:57:35.000+01:00
diff --git a/src/flex-table.cpp b/src/flex-table.cpp
@@ -398,12 +398,11 @@ pg_result_t table_connection_t::get_geom_by_id(osmium::item_type type,
 {
     assert(table().has_geom_column());
     assert(m_db_connection);
-    std::string const id_str = fmt::to_string(id);
     if (table().has_multicolumn_id_index()) {
-        return m_db_connection->exec_prepared(
-            "get_wkb", type_to_char(type), id_str.c_str());
+        return m_db_connection->exec_prepared("get_wkb", type_to_char(type),
+                                              id);
     }
-    return m_db_connection->exec_prepared("get_wkb", id_str);
+    return m_db_connection->exec_prepared("get_wkb", id);
 }
 
 void table_connection_t::delete_rows_with(osmium::item_type type, osmid_t id)

Original file line number	Diff line number	Diff line change
`@@ -398,12 +398,11 @@ pg_result_t table_connection_t::get_geom_by_id(osmium::item_type type,`
`398`	`398`	`{`
`399`	`399`	`assert(table().has_geom_column());`
`400`	`400`	`assert(m_db_connection);`
`401`		`- std::string const id_str = fmt::to_string(id);`
`402`	`401`	`if (table().has_multicolumn_id_index()) {`
`403`		`- return m_db_connection->exec_prepared(`
`404`		`- "get_wkb", type_to_char(type), id_str.c_str());`
	`402`	`+ return m_db_connection->exec_prepared("get_wkb", type_to_char(type),`
	`403`	`+ id);`
`405`	`404`	`}`
`406`		`- return m_db_connection->exec_prepared("get_wkb", id_str);`
	`405`	`+ return m_db_connection->exec_prepared("get_wkb", id);`
`407`	`406`	`}`
`408`	`407`
`409`	`408`	`void table_connection_t::delete_rows_with(osmium::item_type type, osmid_t id)`