Creating a point geometry_t from a point_t doesn't need move

Because point_t is small and trivially copyable. This makes code a bit
simpler and avoids some warnings from clang-tidy.

Author: joto

src/geom.hpp

@@ -246,8 +246,10 @@ class geometry_t
 public:
     constexpr geometry_t() = default;
 
-    constexpr explicit geometry_t(point_t &&geom, int srid = 4326)
-    : m_geom(geom), m_srid(srid) // geom is trivially copyable, no move needed
+    // point_t is small and trivially copyable, no move needed like for the
+    // other constructors.
+    constexpr explicit geometry_t(point_t geom, int srid = 4326)
+    : m_geom(geom), m_srid(srid)
     {}
 
     constexpr explicit geometry_t(linestring_t &&geom, int srid = 4326)

tests/test-geom-multipoints.cpp

@@ -34,7 +34,7 @@ TEST_CASE("multipoint_t with a single point", "[NoDB]")
     REQUIRE(area(geom) == Approx(0.0));
     REQUIRE(length(geom) == Approx(0.0));
     REQUIRE(reverse(geom) == geom);
-    REQUIRE(centroid(geom) == geom::geometry_t{std::move(point)});
+    REQUIRE(centroid(geom) == geom::geometry_t{point});
 
     REQUIRE(mp[0] == expected);
 }
@@ -63,9 +63,9 @@ TEST_CASE("multipoint_t with several points", "[NoDB]")
     REQUIRE(mp[1] == p1);
     REQUIRE(mp[2] == p2);
 
-    REQUIRE(geometry_n(geom, 1) == geom::geometry_t{std::move(p0)});
-    REQUIRE(geometry_n(geom, 2) == geom::geometry_t{std::move(p1)});
-    REQUIRE(geometry_n(geom, 3) == geom::geometry_t{std::move(p2)});
+    REQUIRE(geometry_n(geom, 1) == geom::geometry_t{p0});
+    REQUIRE(geometry_n(geom, 2) == geom::geometry_t{p1});
+    REQUIRE(geometry_n(geom, 3) == geom::geometry_t{p2});
 }
 
 TEST_CASE("create_multipoint from OSM data", "[NoDB]")

tests/test-geom-output.cpp

@@ -33,7 +33,7 @@ TEST_CASE("point_t output", "[NoDB]")
     ss1 << g;
     CHECK(ss1.str() == "1 2");
 
-    geom::geometry_t geom{std::move(g)};
+    geom::geometry_t geom{g};
     std::stringstream ss2;
     ss2 << geom;
     CHECK(ss2.str() == "POINT(1 2)");