Merge pull request #2174 from joto/misc-cleanup

Various small cleanups

Author: lonvia

src/flex-table.cpp

@@ -279,7 +279,8 @@ static void enable_check_trigger(pg_conn_t const &db_connection,
                               checks);
 }
 
-void table_connection_t::start(pg_conn_t const &db_connection, bool append)
+void table_connection_t::start(pg_conn_t const &db_connection,
+                               bool append) const
 {
     if (!append) {
         drop_table_if_exists(db_connection, table().schema(), table().name());

src/flex-table.hpp

@@ -281,7 +281,7 @@ class table_connection_t
     {
     }
 
-    void start(pg_conn_t const &db_connection, bool append);
+    void start(pg_conn_t const &db_connection, bool append) const;
 
     void stop(pg_conn_t const &db_connection, bool updateable, bool append);
 

src/geom-from-osm.cpp

@@ -170,7 +170,7 @@ void create_multilinestring(geometry_t *geom,
         // retroactively.
         if (multiline.num_geometries() == 1 && !force_multi) {
             // This has to be done in two steps, because the set<>()
-            // destroys the content of mulitline.
+            // destroys the content of multiline.
             auto p = std::move(multiline[0]);
             geom->set<linestring_t>() = std::move(p);
         }

tests/bdd/flex/bbox.feature

@@ -75,7 +75,7 @@ Feature: Test get_bbox() function
             """
             w20 v1 dV Nn10,n11
             w21 v1 dV Nn11,n12
-            r30 v1 dV Ttype=route,route=bus Mw20@@
+            r30 v1 dV Ttype=route,route=bus Mw20@
             r31 v1 dV Ttype=route,route=bus Mw20@,w21@
             """
         And the lua style

tests/test-pgsql.cpp

@@ -138,7 +138,7 @@ TEST_CASE("create table and insert something")
 
 TEST_CASE("empty result object should return fatal status")
 {
-    pg_result_t result;
+    pg_result_t const result;
     REQUIRE(result.status() == PGRES_FATAL_ERROR);
     REQUIRE_FALSE(result);
     REQUIRE(result.num_fields() == 0);