Mark some cases NOLINT

clang-tidy throws bugprone-empty-catch, but in all these cases there is
a good and documented reason for the empty catch.

Author: joto

include/osmium/io/bzip2_compression.hpp

@@ -195,7 +195,7 @@ namespace osmium {
             ~Bzip2Compressor() noexcept override {
                 try {
                     close();
-                } catch (...) {
+                } catch (...) { // NOLINT(bugprone-empty-catch)
                     // Ignore any exceptions because destructor must not throw.
                 }
             }
@@ -269,7 +269,7 @@ namespace osmium {
             ~Bzip2Decompressor() noexcept override {
                 try {
                     close();
-                } catch (...) {
+                } catch (...) { // NOLINT(bugprone-empty-catch)
                     // Ignore any exceptions because destructor must not throw.
                 }
             }
@@ -377,7 +377,7 @@ namespace osmium {
             ~Bzip2BufferDecompressor() noexcept override {
                 try {
                     close();
-                } catch (...) {
+                } catch (...) { // NOLINT(bugprone-empty-catch)
                     // Ignore any exceptions because destructor must not throw.
                 }
             }

include/osmium/io/compression.hpp

@@ -246,7 +246,7 @@ namespace osmium {
             ~NoCompressor() noexcept override {
                 try {
                     close();
-                } catch (...) {
+                } catch (...) { // NOLINT(bugprone-empty-catch)
                     // Ignore any exceptions because destructor must not throw.
                 }
             }
@@ -337,7 +337,7 @@ namespace osmium {
             ~NoDecompressor() noexcept override {
                 try {
                     close();
-                } catch (...) {
+                } catch (...) { // NOLINT(bugprone-empty-catch)
                     // Ignore any exceptions because destructor must not throw.
                 }
             }

include/osmium/io/detail/queue_util.hpp

@@ -117,7 +117,8 @@ namespace osmium {
                 ~queue_wrapper() noexcept {
                     try {
                         shutdown();
-                    } catch (...) {
+                    } catch (...) { // NOLINT(bugprone-empty-catch)
+                        // Ignore any exceptions because destructor must not throw.
                     }
                 }
 

include/osmium/io/gzip_compression.hpp

@@ -131,7 +131,7 @@ namespace osmium {
             ~GzipCompressor() noexcept override {
                 try {
                     close();
-                } catch (...) {
+                } catch (...) { // NOLINT(bugprone-empty-catch)
                     // Ignore any exceptions because destructor must not throw.
                 }
             }
@@ -196,7 +196,7 @@ namespace osmium {
                 if (!m_gzfile) {
                     try {
                         osmium::io::detail::reliable_close(fd);
-                    } catch (...) {
+                    } catch (...) { // NOLINT(bugprone-empty-catch)
                     }
                     throw gzip_error{"gzip error: read initialization failed"};
                 }
@@ -211,7 +211,7 @@ namespace osmium {
             ~GzipDecompressor() noexcept override {
                 try {
                     close();
-                } catch (...) {
+                } catch (...) { // NOLINT(bugprone-empty-catch)
                     // Ignore any exceptions because destructor must not throw.
                 }
             }
@@ -293,7 +293,7 @@ namespace osmium {
             ~GzipBufferDecompressor() noexcept override {
                 try {
                     close();
-                } catch (...) {
+                } catch (...) { // NOLINT(bugprone-empty-catch)
                     // Ignore any exceptions because destructor must not throw.
                 }
             }

include/osmium/io/reader.hpp

@@ -368,7 +368,7 @@ namespace osmium {
             ~Reader() noexcept {
                 try {
                     close();
-                } catch (...) {
+                } catch (...) { // NOLINT(bugprone-empty-catch)
                     // Ignore any exceptions because destructor must not throw.
                 }
             }

include/osmium/io/writer.hpp

@@ -308,7 +308,7 @@ namespace osmium {
             ~Writer() noexcept {
                 try {
                     do_close();
-                } catch (...) {
+                } catch (...) { // NOLINT(bugprone-empty-catch)
                     // Ignore any exceptions because destructor must not throw.
                 }
             }

include/osmium/util/memory_mapping.hpp

@@ -228,7 +228,7 @@ namespace osmium {
             ~MemoryMapping() noexcept {
                 try {
                     unmap();
-                } catch (const std::system_error&) {
+                } catch (const std::system_error&) { // NOLINT(bugprone-empty-catch)
                     // Ignore any exceptions because destructor must not throw.
                 }
             }
@@ -591,7 +591,7 @@ inline osmium::util::MemoryMapping::MemoryMapping(MemoryMapping&& other) noexcep
 inline osmium::util::MemoryMapping& osmium::util::MemoryMapping::operator=(osmium::util::MemoryMapping&& other) noexcept {
     try {
         unmap();
-    } catch (const std::system_error&) {
+    } catch (const std::system_error&) { // NOLINT(bugprone-empty-catch)
         // Ignore unmap error. It should never happen anyway and we can't do
         // anything about it here.
     }
@@ -761,7 +761,7 @@ inline osmium::util::MemoryMapping::MemoryMapping(MemoryMapping&& other) noexcep
 inline osmium::util::MemoryMapping& osmium::util::MemoryMapping::operator=(osmium::util::MemoryMapping&& other) noexcept {
     try {
         unmap();
-    } catch (const std::system_error&) {
+    } catch (const std::system_error&) { // NOLINT(bugprone-empty-catch)
         // Ignore unmap error. It should never happen anyway and we can't do
         // anything about it here.
     }