Bugfix: Avoid integer overflow in o5m parser

joto · joto · commit 4dd1f9a116ef · 2021-04-20T09:24:49.000+02:00
See #329
diff --git a/include/osmium/io/detail/o5m_input_format.hpp b/include/osmium/io/detail/o5m_input_format.hpp
@@ -166,7 +166,7 @@ namespace osmium {
                 }
 
                 bool ensure_bytes_available(std::size_t need_bytes) {
-                    if ((m_end - m_data) >= static_cast<int64_t>(need_bytes)) {
+                    if (static_cast<std::size_t>(m_end - m_data) >= need_bytes) {
                         return true;
                     }
 

Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,7 @@ namespace osmium {`
`166`	`166`	`}`
`167`	`167`
`168`	`168`	`bool ensure_bytes_available(std::size_t need_bytes) {`
`169`		`- if ((m_end - m_data) >= static_cast<int64_t>(need_bytes)) {`
	`169`	`+ if (static_cast<std::size_t>(m_end - m_data) >= need_bytes) {`
`170`	`170`	`return true;`
`171`	`171`	`}`
`172`	`172`