clang-tidy: Make const what can be const

Author: joto

src/app.cpp

@@ -43,7 +43,7 @@ void BasicApp::pre()
 
 void BasicApp::post()
 {
-    osmium::MemoryUsage mem;
+    const osmium::MemoryUsage mem;
     vout() << fmt::format(
         "Overall memory usage: {} MByte current, {} MBytes peak\n",
         mem.current(), mem.peak());

src/osp-find-colocated-nodes.cpp

@@ -414,7 +414,7 @@ try {
                         handler.stats().relations_referencing_colocated_nodes);
                 });
 
-    osmium::MemoryUsage memory_usage;
+    const osmium::MemoryUsage memory_usage;
     if (memory_usage.peak() != 0) {
         vout << "Peak memory usage: " << memory_usage.peak() << " MBytes\n";
     }

src/osp-find-multipolygon-problems.cpp

@@ -242,7 +242,7 @@ try {
 
     CheckMPManager manager{&outputs, options};
 
-    osmium::io::File file{input_filename};
+    const osmium::io::File file{input_filename};
     osmium::relations::read_relations(file, manager);
 
     vout << "Reading ways and checking for problems...\n";
@@ -290,7 +290,7 @@ try {
             });
         });
 
-    osmium::MemoryUsage memory_usage;
+    const osmium::MemoryUsage memory_usage;
     if (memory_usage.peak() != 0) {
         vout << "Peak memory usage: " << memory_usage.peak() << " MBytes\n";
     }

src/osp-find-orphans.cpp

@@ -357,7 +357,7 @@ try {
                     add("orphan_relations", handler.stats().orphan_relations);
                 });
 
-    osmium::MemoryUsage memory_usage;
+    const osmium::MemoryUsage memory_usage;
     if (memory_usage.peak() != 0) {
         vout << "Peak memory usage: " << memory_usage.peak() << " MBytes\n";
     }

src/osp-find-relation-problems.cpp

@@ -381,7 +381,7 @@ try {
              << " (change with --age, -a or --before, -b)\n";
     }
 
-    osmium::io::File file{input_filename};
+    const osmium::io::File file{input_filename};
     osmium::io::Reader reader{file, osmium::osm_entity_bits::relation};
     if (file.format() == osmium::io::file_format::pbf &&
         !has_locations_on_ways(reader.header())) {
@@ -443,7 +443,7 @@ try {
                     });
                 });
 
-    osmium::MemoryUsage memory_usage;
+    const osmium::MemoryUsage memory_usage;
     if (memory_usage.peak() != 0) {
         vout << "Peak memory usage: " << memory_usage.peak() << " MBytes\n";
     }

src/osp-find-unusual-tags.cpp

@@ -400,7 +400,7 @@ try {
                 handler.stats().r_tag_boundary_multipolygon);
         });
 
-    osmium::MemoryUsage memory_usage;
+    const osmium::MemoryUsage memory_usage;
     if (memory_usage.peak() != 0) {
         vout << "Peak memory usage: " << memory_usage.peak() << " MBytes\n";
     }

src/osp-find-way-problems.cpp

@@ -737,7 +737,7 @@ try {
              << " (change with --age, -a or --before, -b)\n";
     }
 
-    osmium::io::File file{input_filename};
+    const osmium::io::File file{input_filename};
     osmium::io::Reader reader{file, osmium::osm_entity_bits::way};
     if (file.format() == osmium::io::file_format::pbf &&
         !has_locations_on_ways(reader.header())) {
@@ -778,7 +778,7 @@ try {
             add("way_long_segment", handler.stats().long_segment);
         });
 
-    osmium::MemoryUsage memory_usage;
+    const osmium::MemoryUsage memory_usage;
     if (memory_usage.peak() != 0) {
         vout << "Peak memory usage: " << memory_usage.peak() << " MBytes\n";
     }