Fix unique ids in JSON output

Fixes #287

Author: joto

src/export/export_format_json.cpp

@@ -87,9 +87,10 @@ void ExportFormatJSON::start_feature(const std::string& prefix, osmium::object_i
         m_buffer += R"(,"id":)";
         m_buffer += std::to_string(m_count + 1);
     } else if (options().unique_id == unique_id_type::type_id) {
-        m_buffer += R"(,"id":)";
+        m_buffer += R"(,"id":")";
         m_buffer += prefix;
         m_buffer += std::to_string(id);
+        m_buffer += '"';
     }
 }
 

test/export/CMakeLists.txt

@@ -12,6 +12,8 @@ endfunction()
 
 check_export(geojson    "-f geojson"       input.osm output.geojson)
 check_export(geojsonseq "-f geojsonseq -x print_record_separator=false" input.osm output.geojsonseq)
+check_export(geojsonuid "-f geojsonseq -u type_id" input.osm output-uid.geojsonseq)
+check_export(geojsoncnt "-f geojsonseq -u counter" input.osm output-cnt.geojsonseq)
 check_export(pg         "-f pg"            input.osm output.pg)
 
 check_export(missing-node "-f geojson" input-missing-node.osm output-missing-node.geojson)

test/export/output-cnt.geojsonseq

@@ -0,0 +1,4 @@
+{"type":"Feature","id":1,"geometry":{"type":"Point","coordinates":[2.0,1.5]},"properties":{"amenity":"post_box"}}
+{"type":"Feature","id":2,"geometry":{"type":"LineString","coordinates":[[1.0,1.0],[1.0,2.0],[1.0,3.0]]},"properties":{"highway":"track"}}
+{"type":"Feature","id":3,"geometry":{"type":"LineString","coordinates":[[1.0,1.0],[1.0,2.0],[2.0,1.5]]},"properties":{"barrier":"fence"}}
+{"type":"Feature","id":4,"geometry":{"type":"MultiPolygon","coordinates":[[[[1.0,1.0],[2.0,1.5],[1.0,2.0],[1.0,1.0]]]]},"properties":{"landuse":"forest"}}

test/export/output-uid.geojsonseq

@@ -0,0 +1,4 @@
+{"type":"Feature","id":"n14","geometry":{"type":"Point","coordinates":[2.0,1.5]},"properties":{"amenity":"post_box"}}
+{"type":"Feature","id":"w20","geometry":{"type":"LineString","coordinates":[[1.0,1.0],[1.0,2.0],[1.0,3.0]]},"properties":{"highway":"track"}}
+{"type":"Feature","id":"w21","geometry":{"type":"LineString","coordinates":[[1.0,1.0],[1.0,2.0],[2.0,1.5]]},"properties":{"barrier":"fence"}}
+{"type":"Feature","id":"a61","geometry":{"type":"MultiPolygon","coordinates":[[[[1.0,1.0],[2.0,1.5],[1.0,2.0],[1.0,1.0]]]]},"properties":{"landuse":"forest"}}