-
Notifications
You must be signed in to change notification settings - Fork 77
Description
Description
ComplexRoundabout validation combining multiple errors into single ComplexEntityError. This approach makes more difficult adding an AutoFix suggestion to MalformedRoundaboutCheck.
Proposal
Break ComplexEntityError into individual Errors:
Before
WRONG_WAY_INVALIDATION = "This roundabout is going the wrong direction, or has been improperly tagged as a roundabout.";
After
WRONG_WAY_INVALIDATION = "This roundabout is going the wrong direction";
WRONG_WAY_TAGGING = "This way has been improperly tagged as a roundabout.";
Example 1
Wrong Way
Autofix suggestion - reverse geometry
Example 2
Wrong tagging
Autofix suggestion - remove junction=roundabout tag.
Currently both cases falls with the same error message and can't be differentiated for Autofix implementation.