BE-723 | Fix 0 liquidity pools for candidate routes (#643)

Some candidate routes have their capitalization set to 0 because that's how it's defined in the block data. As a result, the router avoids routing through these pools. This PR fixes the issue by assigning a liquidity capitalization value to candidate routes with a value retrieved from the pools use case, which provides the most up-to-date data.

Author: deividaspetraitis

app/sidecar_query_server.go

@@ -6,7 +6,6 @@ import (
 	"net"
 	"net/http"
 	"os"
-
 	"time"
 
 	tenderminapi "cosmossdk.io/api/cosmos/base/tendermint/v1beta1"
@@ -168,6 +167,8 @@ func NewSideCarQueryServer(ctx context.Context, appCodec codec.Codec, config dom
 		return nil, err
 	}
 
+	routerRepository.SetPoolHandler(poolsUseCase)
+
 	// Initialize candidate route searcher
 	candidateRouteSearcher := routerUseCase.NewCandidateRouteFinder(routerRepository, logger)
 

router/repository/memory_router_repository.go

@@ -13,6 +13,7 @@ import (
 	"github.com/osmosis-labs/sqs/log"
 
 	"github.com/osmosis-labs/osmosis/osmomath"
+	sqsosmomath "github.com/osmosis-labs/sqs/domain/osmomath"
 )
 
 // BaseFeeRepository represents the contract for a repository handling base fee information
@@ -48,6 +49,7 @@ type candidateRoutes map[string]*domain.CandidateRouteDenomData
 type routerRepo struct {
 	takerFeeMap              sync.Map
 	candidateRouteSearchData atomic.Value
+	poolHandler              mvc.PoolHandler
 	mu                       sync.Mutex
 
 	baseFeeMx sync.RWMutex
@@ -56,7 +58,7 @@ type routerRepo struct {
 	logger log.Logger
 }
 
-func New(logger log.Logger) RouterRepository {
+func New(logger log.Logger) *routerRepo {
 	repository := &routerRepo{
 		takerFeeMap: sync.Map{},
 		baseFeeMx:   sync.RWMutex{},
@@ -69,6 +71,10 @@ func New(logger log.Logger) RouterRepository {
 	return repository
 }
 
+func (r *routerRepo) SetPoolHandler(poolHandler mvc.PoolHandler) {
+	r.poolHandler = poolHandler
+}
+
 // GetBaseFee implements RouterRepository.
 func (r *routerRepo) GetBaseFee() domain.BaseFee {
 	r.baseFeeMx.RLock()
@@ -177,6 +183,25 @@ func (r *routerRepo) SetCandidateRouteSearchData(data map[string]*domain.Candida
 
 	maps.Copy(newData, oldData)
 
+	// Some of the pools from the block data may not have a liquidity cap set or it's set to 0.
+	// Here we manually update the liquidity cap for such candidate routes based on the pool data so
+	// that we can still route over such pools.
+	for denom, value := range newData {
+		for i := range value.SortedPools {
+			if value.SortedPools[i].PoolLiquidityCap == 0 {
+				p, _, err := r.poolHandler.GetPools(domain.WithPoolIDFilter([]uint64{value.SortedPools[i].ID}))
+				if len(p) == 0 || err != nil {
+					continue // no pool found
+				}
+
+				if p[0].GetLiquidityCap().GT(osmomath.ZeroInt()) {
+					newData[denom].SortedPools[i].PoolLiquidityCap = sqsosmomath.SafeUint64(p[0].GetLiquidityCap())
+				}
+			}
+		}
+	}
+
+	// Update new data with block data
 	for denom, value := range data {
 		newData[denom] = value
 	}