Skip to content

Commit 0bb397b

Browse files
authored
Merge pull request #251 from osociety/codecov-fix
Fix codecov issue
2 parents 5816857 + 97149f5 commit 0bb397b

File tree

2 files changed

+36
-16
lines changed

2 files changed

+36
-16
lines changed

.github/workflows/dart.yml

Lines changed: 36 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,43 @@ jobs:
4545
- name: Analyze project source
4646
run: dart analyze --fatal-infos
4747

48-
# Your project will need to have tests in test/ and a dependency on
49-
# package:test for this step to succeed. Note that Flutter projects will
50-
# want to change this to 'flutter test'.
5148
- name: Run tests
52-
run: dart test
49+
run: dart test --coverage="./coverage"
50+
51+
- name: Install coverage tools
52+
if: runner.os == 'Linux'
53+
run: dart pub global activate coverage
54+
55+
- name: Install lcov
56+
if: runner.os == 'Linux'
57+
run: sudo apt-get update && sudo apt-get install -y lcov
58+
59+
- name: Format Coverage
60+
if: runner.os == 'Linux'
61+
run: dart pub global run coverage:format_coverage --packages=.dart_tool/package_config.json --report-on=lib --lcov -o ./coverage/coverage.lcov -i ./coverage
62+
63+
- name: Excluded generated files
64+
if: runner.os == 'Linux'
65+
run: lcov --remove ./coverage/coverage.lcov '*/lib/src/*.g.dart' '*/lib/src/models/drift/*' -o ./coverage/coverage.lcov
66+
67+
- name: Generate HTML coverage report
68+
if: runner.os == 'Linux'
69+
run: genhtml -o ./coverage/report ./coverage/coverage.lcov
70+
71+
- name: Upload artifact
72+
if: runner.os == 'Linux'
73+
uses: actions/upload-pages-artifact@v3
74+
with:
75+
# Upload entire repository
76+
path: './coverage/report'
5377

78+
- name: Upload coverage to Codecov
79+
if: runner.os == 'Linux'
80+
uses: codecov/codecov-action@v3
81+
with:
82+
files: ./coverage/coverage.lcov
83+
flags: unittests
84+
name: codecov-umbrella
85+
5486
- name: Check Publish Warnings
5587
run: dart pub publish --dry-run

test/network_tools_test.dart

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -310,18 +310,6 @@ Future<void> main() async {
310310
});
311311
});
312312

313-
group("Testing mdns scanner group", () {
314-
test('Running searchMdnsDevices tests', () async {
315-
final mdnsDevices = await MdnsScannerService.instance.searchMdnsDevices();
316-
expectLater(mdnsDevices, isA<List<ActiveHost>>());
317-
//todo: mdnsDevices are empty in GHA, open one to be discoverable
318-
// expectLater(
319-
// mdnsDevices,
320-
// contains(predicate<ActiveHost>((host) => host.address == myOwnHost)),
321-
// );
322-
});
323-
});
324-
325313
tearDownAll(() {
326314
server.close();
327315
});

0 commit comments

Comments
 (0)