Skip to content

Fix codecov issue 2 #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
git-elliot merged 5 commits into from
Dec 3, 2025
Merged

Fix codecov issue 2 #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7c804ee
Fix codecov issue
git-elliot Dec 3, 2025
bbebcbe
fix lcov upload
git-elliot Dec 3, 2025
7a4a883
fix codecov upload
git-elliot Dec 3, 2025
dc3757a
skip activate coverage
git-elliot Dec 3, 2025
97149f5
mdns devices are not available on windows
git-elliot Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 36 additions & 4 deletions .github/workflows/dart.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,43 @@ jobs:
- name: Analyze project source
run: dart analyze --fatal-infos

# Your project will need to have tests in test/ and a dependency on
# package:test for this step to succeed. Note that Flutter projects will
# want to change this to 'flutter test'.
- name: Run tests
run: dart test
run: dart test --coverage="./coverage"

- name: Install coverage tools
if: runner.os == 'Linux'
run: dart pub global activate coverage

- name: Install lcov
if: runner.os == 'Linux'
run: sudo apt-get update && sudo apt-get install -y lcov

- name: Format Coverage
if: runner.os == 'Linux'
run: dart pub global run coverage:format_coverage --packages=.dart_tool/package_config.json --report-on=lib --lcov -o ./coverage/coverage.lcov -i ./coverage

- name: Excluded generated files
if: runner.os == 'Linux'
run: lcov --remove ./coverage/coverage.lcov '*/lib/src/*.g.dart' '*/lib/src/models/drift/*' -o ./coverage/coverage.lcov

- name: Generate HTML coverage report
if: runner.os == 'Linux'
run: genhtml -o ./coverage/report ./coverage/coverage.lcov

- name: Upload artifact
if: runner.os == 'Linux'
uses: actions/upload-pages-artifact@v3
with:
# Upload entire repository
path: './coverage/report'

- name: Upload coverage to Codecov
if: runner.os == 'Linux'
uses: codecov/codecov-action@v3
with:
files: ./coverage/coverage.lcov
flags: unittests
name: codecov-umbrella

- name: Check Publish Warnings
run: dart pub publish --dry-run
12 changes: 0 additions & 12 deletions test/network_tools_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,18 +310,6 @@ Future<void> main() async {
});
});

group("Testing mdns scanner group", () {
test('Running searchMdnsDevices tests', () async {
final mdnsDevices = await MdnsScannerService.instance.searchMdnsDevices();
expectLater(mdnsDevices, isA<List<ActiveHost>>());
//todo: mdnsDevices are empty in GHA, open one to be discoverable
// expectLater(
// mdnsDevices,
// contains(predicate<ActiveHost>((host) => host.address == myOwnHost)),
// );
});
});

tearDownAll(() {
server.close();
});
Expand Down