Skip to content

Commit 6b63f95

Browse files
jacobperronivanpauno
authored andcommitted
Enable and fix AsyncParametersClientTest (#51)
Now we're actually running the tests. This also fixes a bug where we were comparing the wrong objects in one of the tests. Signed-off-by: Jacob Perron <[email protected]>
1 parent 166834f commit 6b63f95

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

rcljava/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -289,6 +289,7 @@ if(BUILD_TESTING)
289289
"org.ros2.rcljava.node.NodeParametersTest"
290290
"org.ros2.rcljava.node.NodeUndeclaredParametersTest"
291291
"org.ros2.rcljava.node.NodeTest"
292+
"org.ros2.rcljava.parameters.AsyncParametersClientTest"
292293
"org.ros2.rcljava.parameters.SyncParametersClientTest"
293294
"org.ros2.rcljava.publisher.PublisherTest"
294295
"org.ros2.rcljava.qos.QoSProfileTest"

rcljava/src/test/java/org/ros2/rcljava/parameters/AsyncParametersClientTest.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,8 +119,14 @@ public final void testSetParameters() throws Exception {
119119
List<String> parameterNames =
120120
Arrays.asList(new String[] {"foo", "bar", "baz", "foo.first", "foo.second", "foobar"});
121121

122+
List<rcl_interfaces.msg.SetParametersResult> setParametersResults = future.get();
123+
assertEquals(6, setParametersResults.size());
124+
for (rcl_interfaces.msg.SetParametersResult result : setParametersResults) {
125+
assertEquals(true, result.getSuccessful());
126+
}
127+
122128
List<ParameterVariant> results = node.getParameters(parameterNames);
123-
assertEquals(parameters, future.get());
129+
assertEquals(parameters, results);
124130
}
125131

126132
@Test

0 commit comments

Comments
 (0)