Skip to content

Commit bdecfa7

Browse files
committed
Add getter for UUID to SendGoalRequest
Also make inner classes static. Signed-off-by: Jacob Perron <[email protected]>
1 parent 768b6d4 commit bdecfa7

File tree

2 files changed

+12
-9
lines changed

2 files changed

+12
-9
lines changed

rcljava_common/src/main/java/org/ros2/rcljava/interfaces/GoalRequestDefinition.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,9 @@
1515

1616
package org.ros2.rcljava.interfaces;
1717

18+
import java.util.List;
19+
1820
public interface GoalRequestDefinition extends MessageDefinition {
19-
ActionDefinition.ActionGoal getAbstractGoal();
20-
// TODO: Add getGoalId();
21+
MessageDefinition getGoal();
22+
List<Byte> getGoalUuid();
2123
}

rosidl_generator_java/resource/action.java.em

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ expand_template(
6363
template_basepath=template_basepath)
6464

6565
action_imports = [
66+
'java.util.List',
6667
'org.ros2.rcljava.common.JNIUtils',
6768
'org.ros2.rcljava.interfaces.ActionDefinition',
6869
'org.ros2.rcljava.interfaces.GoalRequestDefinition',
@@ -79,19 +80,19 @@ import @(action_import);
7980

8081
public class @(type_name) implements ActionDefinition {
8182

82-
public class Goal extends @(type_name)_Goal implements ActionGoal<@(type_name)> {}
83+
public static class Goal extends @(type_name)_Goal implements ActionGoal<@(type_name)> {}
8384

84-
public class Result extends @(type_name)_Result implements ActionResult<@(type_name)> {}
85+
public static class Result extends @(type_name)_Result implements ActionResult<@(type_name)> {}
8586

86-
public class Feedback extends @(type_name)_Feedback implements ActionFeedback<@(type_name)> {}
87+
public static class Feedback extends @(type_name)_Feedback implements ActionFeedback<@(type_name)> {}
8788

88-
public class SendGoalRequest extends @(type_name)_SendGoal_Request implements GoalRequestDefinition {
89-
public ActionDefinition.ActionGoal getAbstractGoal() {
90-
return (Goal)super.getGoal();
89+
public static class SendGoalRequest extends @(type_name)_SendGoal_Request implements GoalRequestDefinition {
90+
public List<Byte> getGoalUuid() {
91+
return super.getGoalId().getUuid();
9192
}
9293
}
9394

94-
public class SendGoalResponse extends @(type_name)_SendGoal_Response implements GoalResponseDefinition {
95+
public static class SendGoalResponse extends @(type_name)_SendGoal_Response implements GoalResponseDefinition {
9596
public void accept(boolean accepted) {
9697
super.setAccepted(accepted);
9798
}

0 commit comments

Comments
 (0)