Feat 142 archive group (#326)

krokosik · web-flow · commit d30c81c98067 · 2025-08-25T00:12:46.000+02:00
* Update schema with the archived field

* Expand locale files for the change

* Add and update api routes

* Add ui elements in group page

* Add accordion with archived groups

* Fix bugs in add members dialog

* Remove archived from common

* Add backend checks for editing archived group
diff --git a/prisma/migrations/20250824205700_add_archived_at_to_group/migration.sql b/prisma/migrations/20250824205700_add_archived_at_to_group/migration.sql
@@ -0,0 +1,2 @@
+-- AlterTable
+ALTER TABLE "Group" ADD COLUMN     "archivedAt" TIMESTAMP(3);
diff --git a/prisma/schema.prisma b/prisma/schema.prisma
@@ -96,6 +96,7 @@ model Group {
     defaultCurrency  String         @default("USD")
     createdAt        DateTime       @default(now())
     updatedAt        DateTime       @updatedAt
+    archivedAt       DateTime?
     splitwiseGroupId String?        @unique
     createdBy        User           @relation(fields: [userId], references: [id], onDelete: Cascade)
     groupUsers       GroupUser[]
diff --git a/public/locales/de/groups_details.json b/public/locales/de/groups_details.json
@@ -48,6 +48,13 @@
       "recalculate_balances_details": {
         "title": "Bist du sicher?",
         "description": "Wenn die Salden nicht mit den Ausgaben übereinstimmen, kannst du sie neu berechnen. Das kann je nach Anzahl der Ausgaben etwas dauern. Salden außerhalb der Gruppe werden nicht beeinflusst."
+      },
+      "archive_group": "Archiviere Gruppe",
+      "archived": "Archiviert",
+      "archive_group_details": {
+        "title": "Bist du sicher, dass du diese Gruppe archivieren möchtest?",
+        "can_archive": "Diese Gruppe wird archiviert und aus deiner Hauptgruppen-Liste ausgeblendet. Du kannst später noch darauf zugreifen, falls nötig.",
+        "cant_archive": "Gruppe mit ausstehenden Salden kann nicht archiviert werden. Alle Salden müssen zuerst ausgeglichen werden."
       }
     },
     "tabs": {
@@ -56,7 +63,8 @@
     },
     "messages": {
       "group_name_updated": "Gruppenname aktualisiert",
-      "balances_recalculated": "Salden erfolgreich neu berechnet"
+      "balances_recalculated": "Salden erfolgreich neu berechnet",
+      "group_archived": "Gruppe erfolgreich archiviert"
     },
     "errors": {
       "group_name_update_failed": "Fehler beim Aktualisieren des Gruppennamens",
diff --git a/public/locales/en/groups_details.json b/public/locales/en/groups_details.json
@@ -47,6 +47,13 @@
       "recalculate_balances_details": {
         "title": "Are you sure?",
         "description": "If balances do not match expenses, you can recalculate them. Note that it may take some time if the expense count is large. Balances outside the group will not be affected."
+      },
+      "archive_group": "Archive group",
+      "archived": "Archived",
+      "archive_group_details": {
+        "title": "Are you sure you want to archive this group?",
+        "can_archive": "This group will be archived and hidden from your main groups list. You can still access it later if needed.",
+        "cant_archive": "Cannot archive group with outstanding balances. All balances must be settled first."
       }
     },
     "tabs": {
@@ -55,7 +62,8 @@
     },
     "messages": {
       "group_name_updated": "Updated group name",
-      "balances_recalculated": "Balances recalculated successfully"
+      "balances_recalculated": "Balances recalculated successfully",
+      "group_archived": "Group archived successfully"
     },
     "errors": {
       "group_name_update_failed": "Error in updating group name",
diff --git a/public/locales/it/groups_details.json b/public/locales/it/groups_details.json
@@ -47,6 +47,13 @@
       "recalculate_balances_details": {
         "title": "Sei sicuro?",
         "description": "Se i saldi non corrispondono alle spese, puoi ricalcolarli. Nota che potrebbe richiedere del tempo se il numero di spese è elevato. I saldi esterni al gruppo non saranno interessati."
+      },
+      "archive_group": "Archivia gruppo",
+      "archived": "Archiviato",
+      "archive_group_details": {
+        "title": "Sei sicuro di voler archiviare questo gruppo?",
+        "can_archive": "Questo gruppo verrà archiviato e nascosto dalla tua lista principale dei gruppi. Potrai comunque accedervi più tardi se necessario.",
+        "cant_archive": "Non è possibile archiviare un gruppo con saldi in sospeso. Tutti i saldi devono essere saldati prima."
       }
     },
     "tabs": {
@@ -55,7 +62,8 @@
     },
     "messages": {
       "group_name_updated": "Nome del gruppo aggiornato",
-      "balances_recalculated": "Saldi ricalcolati con successo"
+      "balances_recalculated": "Saldi ricalcolati con successo",
+      "group_archived": "Gruppo archiviato con successo"
     },
     "errors": {
       "group_name_update_failed": "Errore nell'aggiornamento del nome del gruppo",
diff --git a/public/locales/pl/expense_details.json b/public/locales/pl/expense_details.json
@@ -70,7 +70,7 @@
     },
     "balance_list": {
       "press_balance_info": "Naciśnij na poszczególne saldo aby rozpocząć rozliczenie",
-      "are_settled_up": "są rozliczeni",
+      "are_settled_up": "rozliczono",
       "is_settled_up": "rozliczono"
     },
     "expense_list": {
diff --git a/public/locales/pl/groups_details.json b/public/locales/pl/groups_details.json
@@ -12,7 +12,7 @@
         "send_invite": "Wyślij zaproszenie do użytkownika",
         "add_to_split_pro": "Dodaj do Split Pro"
       },
-      "invite_link": "Udostępnij link zaproszenia",
+      "invite_link": "Udostępnij link",
       "copied": "Skopiowano"
     },
     "group_statistics": {
@@ -47,6 +47,13 @@
       "recalculate_balances_details": {
         "title": "Na pewno?",
         "description": "Jeśli salda nie odpowiadają wydatkom, możesz je przeliczyć. Uwaga, że może to zająć trochę czasu, jeśli liczba wydatków jest duża. Salda poza grupą nie będą dotknięte."
+      },
+      "archive_group": "Zarchiwizuj grupę",
+      "archived": "Zarchiwizowano",
+      "archive_group_details": {
+        "title": "Na pewno chcesz zarchiwizować tę grupę?",
+        "can_archive": "Ta grupa zostanie zarchiwizowana i ukryta z głównej listy grup. Nadal będziesz mógł uzyskać do niej dostęp później, jeśli będzie to potrzebne.",
+        "cant_archive": "Nie można zarchiwizować grupy z zaległymi saldami. Wszystkie salda muszą być najpierw rozliczone."
       }
     },
     "tabs": {
@@ -55,7 +62,8 @@
     },
     "messages": {
       "group_name_updated": "Zaktualizowano nazwę grupy",
-      "balances_recalculated": "Salda przeliczone pomyślnie"
+      "balances_recalculated": "Salda przeliczone pomyślnie",
+      "group_archived": "Grupa została pomyślnie zarchiwizowana"
     },
     "errors": {
       "group_name_update_failed": "Błąd podczas aktualizacji nazwy grupy",
diff --git a/public/locales/sv/groups_details.json b/public/locales/sv/groups_details.json
@@ -47,6 +47,13 @@
       "recalculate_balances_details": {
         "title": "Är du säker?",
         "description": "Om saldon inte matchar utgifter, kan du räkna om dem. Notera att det kan ta tid om antalet utgifter är stort. Saldon utanför gruppen påverkas inte."
+      },
+      "archive_group": "Arkivera grupp",
+      "archived": "Arkiverad",
+      "archive_group_details": {
+        "title": "Är du säker på att du vill arkivera denna grupp?",
+        "can_archive": "Denna grupp kommer att arkiveras och döljas från din huvudlista över grupper. Du kan fortfarande komma åt den senare om det behövs.",
+        "cant_archive": "Kan inte arkivera grupp med utestående saldon. Alla saldon måste kvittas först."
       }
     },
     "tabs": {
@@ -55,7 +62,8 @@
     },
     "messages": {
       "group_name_updated": "Gruppnamn uppdaterat",
-      "balances_recalculated": "Saldon omräknade"
+      "balances_recalculated": "Saldon omräknade",
+      "group_archived": "Grupp arkiverad framgångsrikt"
     },
     "errors": {
       "group_name_update_failed": "Fel vid uppdatering av gruppnamn",
diff --git a/src/components/group/AddMembers.tsx b/src/components/group/AddMembers.tsx
@@ -109,6 +109,7 @@ const AddMembers: React.FC<{
       onTriggerClick={handleTriggerClick}
       title={t('ui.no_members.add_members_details.title')}
       leftAction={t('ui.actions.cancel', { ns: 'common' })}
+      actionTitle={t('ui.actions.save', { ns: 'common' })}
       actionOnClick={handleActionClick}
       className="h-[85vh]"
       shouldCloseOnAction
@@ -141,7 +142,7 @@ const AddMembers: React.FC<{
               <SendIcon className="mr-2 h-4 w-4" />
               {isEmail.success
                 ? t('ui.no_members.add_members_details.send_invite')
-                : t('ui.errors.valid_email', { ns: 'common' })}
+                : t('common:errors.valid_email')}
             </Button>
           )}
           <Button
@@ -153,7 +154,7 @@ const AddMembers: React.FC<{
             <UserPlusIcon className="mr-2 h-4 w-4" />
             {isEmail.success
               ? t('ui.no_members.add_members_details.add_to_split_pro')
-              : t('ui.errors.valid_email', { ns: 'common' })}
+              : t('common:errors.valid_email')}
           </Button>
         </div>
       </div>
diff --git a/src/components/group/NoMembers.tsx b/src/components/group/NoMembers.tsx
@@ -15,6 +15,7 @@ interface NoMembersProps {
 const NoMembers: React.FC<NoMembersProps> = ({ group, enableSendingInvites }) => {
   const { t } = useTranslation('groups_details');
   const [isCopied, setIsCopied] = useState(false);
+  const isArchived = !!group.archivedAt;
 
   async function copyToClipboard() {
     const inviteLink = `${window.location.origin}/join-group?groupId=${group.publicId}`;
@@ -28,14 +29,18 @@ const NoMembers: React.FC<NoMembersProps> = ({ group, enableSendingInvites }) =>
   return (
     <div className="flex h-full flex-col items-center justify-center gap-4">
       <p className="mb-4 text-center text-gray-500">{t('ui.no_members.no_members')}</p>
-      <Button className="w-[200px]">
+      <Button className="w-[200px]" disabled={isArchived}>
         <AddMembers group={group} enableSendingInvites={enableSendingInvites}>
           <UserPlus className="text-primary-foreground h-5 w-5" />
           <p>{t('ui.no_members.add_members')}</p>
         </AddMembers>
       </Button>
-      <p className="text-gray-400">{t('ui.no_members.or')}</p>
-      <Button className="flex w-[200px] items-center gap-2" onClick={copyToClipboard}>
+      <p className="text-gray-400">{t('common:ui.or')}</p>
+      <Button
+        className="flex w-[200px] items-center gap-2"
+        onClick={copyToClipboard}
+        disabled={isArchived}
+      >
         {!isCopied ? (
           <>
             <Share className="h-5 w-5" />
diff --git a/src/pages/groups.tsx b/src/pages/groups.tsx
@@ -6,14 +6,21 @@ import { BalanceEntry } from '~/components/Expense/BalanceEntry';
 import { CreateGroup } from '~/components/group/CreateGroup';
 import MainLayout from '~/components/Layout/MainLayout';
 import { Button } from '~/components/ui/button';
+import {
+  Accordion,
+  AccordionContent,
+  AccordionItem,
+  AccordionTrigger,
+} from '~/components/ui/accordion';
 import { type NextPageWithUser } from '~/types';
 import { api } from '~/utils/api';
 import { withI18nStaticProps } from '~/utils/i18n/server';
 import { BigMath } from '~/utils/numbers';
 
 const BalancePage: NextPageWithUser = () => {
-  const { t } = useTranslation();
+  const { t } = useTranslation(['groups_details']);
   const groupQuery = api.group.getAllGroupsWithBalances.useQuery();
+  const archivedGroupQuery = api.group.getAllGroupsWithBalances.useQuery({ getArchived: true });
 
   const actions = useMemo(
     () => (
@@ -27,43 +34,75 @@ const BalancePage: NextPageWithUser = () => {
   return (
     <>
       <Head>
-        <title>{t('navigation.groups')}</title>
+        <title>{t('common:navigation.groups')}</title>
       </Head>
-      <MainLayout title={t('navigation.groups')} actions={actions} loading={groupQuery.isPending}>
+      <MainLayout
+        title={t('common:navigation.groups')}
+        actions={actions}
+        loading={groupQuery.isPending}
+      >
         <div className="mt-7 flex flex-col gap-8 pb-36">
           {0 === groupQuery.data?.length ? (
             <div className="mt-[30vh] flex flex-col items-center justify-center gap-20">
               <CreateGroup>
                 <Button>
                   <PlusIcon className="mr-2 h-4 w-4" />
-                  {t('ui.actions.create')}
+                  {t('common:ui.actions.create')}
                 </Button>
               </CreateGroup>
             </div>
           ) : (
-            groupQuery.data?.map((g) => {
-              const [currency, amount] = Object.entries(g.balances).reduce(
-                (acc, balance) => {
-                  if (BigMath.abs(balance[1]) > BigMath.abs(acc[1])) {
-                    return balance;
-                  }
-                  return acc;
-                },
-                [g.defaultCurrency, 0n],
-              );
-              const multiCurrency = 1 < Object.values(g.balances).filter((b) => 0n !== b).length;
-              return (
-                <BalanceEntry
-                  key={g.id}
-                  id={g.id}
-                  entity={g}
-                  amount={amount}
-                  isPositive={0 <= amount}
-                  currency={currency}
-                  hasMore={multiCurrency}
-                />
-              );
-            })
+            <>
+              {/* Active Groups */}
+              {groupQuery.data?.map((g) => {
+                const [currency, amount] = Object.entries(g.balances).reduce(
+                  (acc, balance) => {
+                    if (BigMath.abs(balance[1]) > BigMath.abs(acc[1])) {
+                      return balance;
+                    }
+                    return acc;
+                  },
+                  [g.defaultCurrency, 0n],
+                );
+                const multiCurrency = 1 < Object.values(g.balances).filter((b) => 0n !== b).length;
+                return (
+                  <BalanceEntry
+                    key={g.id}
+                    id={g.id}
+                    entity={g}
+                    amount={amount}
+                    isPositive={0 <= amount}
+                    currency={currency}
+                    hasMore={multiCurrency}
+                  />
+                );
+              })}
+
+              {/* Archived Groups Accordion */}
+              {archivedGroupQuery.data && archivedGroupQuery.data.length > 0 && (
+                <Accordion type="single" collapsible className="w-full">
+                  <AccordionItem value="archived-groups">
+                    <AccordionTrigger className="text-left text-sm text-gray-400">
+                      {t('ui.group_info.archived')} ({archivedGroupQuery.data.length})
+                    </AccordionTrigger>
+                    <AccordionContent>
+                      <div className="mt-7 flex flex-col gap-8">
+                        {archivedGroupQuery.data.map((g) => (
+                          <BalanceEntry
+                            key={g.id}
+                            id={g.id}
+                            entity={g}
+                            amount={0n}
+                            isPositive
+                            currency=""
+                          />
+                        ))}
+                      </div>
+                    </AccordionContent>
+                  </AccordionItem>
+                </Accordion>
+              )}
+            </>
           )}
         </div>
       </MainLayout>
diff --git a/src/pages/groups/[groupId].tsx b/src/pages/groups/[groupId].tsx
diff --git a/src/server/api/routers/expense.ts b/src/server/api/routers/expense.ts
diff --git a/src/server/api/routers/group.ts b/src/server/api/routers/group.ts

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+-- AlterTable`
	`2`	`+ALTER TABLE "Group" ADD COLUMN "archivedAt" TIMESTAMP(3);`