fix: Move SPDX reporter options defaults

Align GitLab Job Template for ORT with how the GitHub action
for ORT[1] works where the template contains the defaults
for variables.

Prior to this change only for manually triggered ORT run
would be generate SPDX reports as JSON and YAML whilst those
triggered in CI would only produce YAML SPDX reports.

[1]: https://github.com/oss-review-toolkit/ort-ci-github-action/blob/9acdf1e/action.yml#L144

Signed-off-by: Thomas Steenbergen <[email protected]>

Author: tsteenbe

.gitlab-ci.yml

@@ -110,7 +110,7 @@ variables:
   ORT_CLI_REPORT_ARGS:
     description: |
       List of arguments to pass to ORT Reporter CLI.
-    value: '-O SpdxDocument=output.file.formats=json,yaml'
+    value: ''
   ORT_CONFIG_REPOSITORY:
     description: |
       URL to ORT configuration repository to use.

templates/ort-scan.yml

@@ -80,6 +80,7 @@
       export ORT_ALLOW_DYNAMIC_VERSIONS=${ALLOW_DYNAMIC_VERSIONS:-"false"}
       export ORT_CLI="/opt/ort/bin/ort"
       export ORT_CLI_ARGS=${ORT_CLI_ARGS:-"-P ort.forceOverwrite=true --stacktrace"}
+      export ORT_CLI_REPORT_ARGS=${ORT_CLI_REPORT_ARGS:-"-O SpdxDocument=output.file.formats=json,yaml"}
       export ORT_CONFIG_PATH=${ORT_CONFIG_PATH:-"${ORT_DATA_PATH}/config"}
       export ORT_CONFIG_VCS_REVISION=${ORT_CONFIG_REVISION:-"main"}
       export ORT_CONFIG_VCS_URL=${ORT_CONFIG_REPOSITORY:-"https://github.com/oss-review-toolkit/ort-config.git"}