refactor: Make license classifications work with old ScanCode versions

For any detected license ORT's ScanCode integration either uses the
license ID from the SPDX license list if present (preferred) or
"LicenseRef-scancode-$key" otherwise.

It may happen that a particular license gets added to the SPDX license
list. ORT's ScanCode integration would then return a `LicenseRef-*`
license identifier if used with an older ScanCode version, and a license
ID from the SPDX license list when used with a recent ScanCode version.

So, adjust the logic to always categorize both license IDs for any
particular license. This makes the most recent classifications
(backwards) compatible with older ScanCode versions.

Signed-off-by: Frank Viernau <[email protected]>

Author: fviernau

tools/curations/buildSrc/src/main/kotlin/ScanCodeLicenseDbClassifications.kt

@@ -136,13 +136,17 @@ private fun downloadLicenseDetailsBatched(
     return result.toMap()
 }
 
-private fun LicenseDetails.getLicenseId(): SpdxSingleLicenseExpression {
-    val expression = spdxLicenseKey ?: "LicenseRef-scancode-$key"
-    return SpdxSingleLicenseExpression.parse(expression)
-}
+private fun LicenseDetails.getLicenseIds(): Set<SpdxSingleLicenseExpression> =
+    listOfNotNull(
+        spdxLicenseKey,
+        "LicenseRef-scancode-$key"
+    ).mapTo(mutableSetOf()) { SpdxSingleLicenseExpression.parse(it) }
 
 private fun LicenseDetails.getCategories(): Set<String> {
-    val overrideLicenseCategory = OVERRIDE_LICENSE_CATEGORIES[getLicenseId()]
+    val overrideLicenseCategory = getLicenseIds().firstNotNullOfOrNull { licenseId ->
+        OVERRIDE_LICENSE_CATEGORIES[licenseId]
+    }
+
     val mappedCategory = when {
         isUnknown -> CATEGORY_UNKNOWN
         isGeneric -> CATEGORY_GENERIC
@@ -169,11 +173,13 @@ private fun getLicenseClassifications(licenseDetails: Collection<LicenseDetails>
         LicenseCategory(category)
     }
 
-    val categorizations = licenseDetails.map { details ->
-        LicenseCategorization(
-            id = details.getLicenseId(),
-            categories = details.getCategories()
-        )
+    val categorizations = licenseDetails.flatMap { details ->
+        details.getLicenseIds().map { licenseId ->
+            LicenseCategorization(
+                id = licenseId,
+                categories = details.getCategories()
+            )
+        }
     }
 
     return LicenseClassifications(