fix(maven): Do not override repository properties with unset values

When setting up the remote repositories to request a remote artifact,
only set the proxy and the authentication if they are actually defined
in the current repository session. Otherwise, properties that might
have been initialized elsewhere (e.g. by Gradle) can be overridden.

While at it, switch from a `map { ... }.toSet()` construct to a `mapTo
(mutableSetOf()) { ... }`.

Signed-off-by: Oliver Heger <[email protected]>

Author: oheger-bosch

plugins/package-managers/maven/src/main/kotlin/utils/MavenSupport.kt

@@ -303,11 +303,12 @@ class MavenSupport(private val workspaceReader: WorkspaceReader) : Closeable {
         val remoteRepositories = allRepositories.filterNot {
             // Some (Linux) file URIs do not start with "file://" but look like "file:/opt/android-sdk-linux".
             it.url.startsWith("file:/")
-        }.map { repository ->
-            val proxy = repositorySystemSession.proxySelector.getProxy(repository)
-            val authentication = repositorySystemSession.authenticationSelector.getAuthentication(repository)
-            RemoteRepository.Builder(repository).setAuthentication(authentication).setProxy(proxy).build()
-        }.toSet()
+        }.mapTo(mutableSetOf()) { repository ->
+            RemoteRepository.Builder(repository).apply {
+                repositorySystemSession.proxySelector.getProxy(repository)?.also(::setProxy)
+                repositorySystemSession.authenticationSelector.getAuthentication(repository)?.also(::setAuthentication)
+            }.build()
+        }
 
         if (allRepositories.size > remoteRepositories.size) {
             logger.debug { "Ignoring local repositories ${allRepositories - remoteRepositories}." }