refactor(scanner): Make ScannerMatcher.configuration non-nullable

No real use-case sets this to `null`, just a test does.

Signed-off-by: Sebastian Schuberth <[email protected]>

Author: sschuberth

scanner/src/main/kotlin/ScannerMatcher.kt

@@ -55,10 +55,9 @@ data class ScannerMatcher(
     val maxVersion: Semver,
 
     /**
-     * Criterion to match the [configuration][ScannerDetails.configuration] of the scanner. If `null`, all
-     * configurations are matched.
+     * Criterion to match the [configuration][ScannerDetails.configuration] of the scanner.
      */
-    val configuration: String?
+    val configuration: String
 ) {
     companion object {
         /**
@@ -94,8 +93,7 @@ data class ScannerMatcher(
         if (!nameRegex.matches(details.name)) return false
 
         val version = Semver(details.version)
-        return version in minVersion..<maxVersion &&
-            (configuration == null || configuration == details.configuration)
+        return version in minVersion..<maxVersion && configuration == details.configuration
     }
 }
 

scanner/src/test/kotlin/ScannerMatcherTest.kt

@@ -106,12 +106,6 @@ class ScannerMatcherTest : WordSpec({
 
             matcher.matches(testDetails) shouldBe false
         }
-
-        "ignore the scanner configuration if it is null" {
-            val matcher = matchingCriteria.copy(configuration = null)
-
-            matcher.matches(testDetails) shouldBe true
-        }
     }
 })