chore(osv-client): Improve error messages

Decode the dedicated error body in case of unsuccessful responses, and
fall back to a message that includes the HTTP code otherwise.

Signed-off-by: Sebastian Schuberth <[email protected]>

Author: sschuberth

clients/osv/src/main/kotlin/Model.kt

@@ -180,3 +180,9 @@ data class Severity(
         CVSS_V3
     }
 }
+
+@Serializable
+data class ErrorResponse(
+    val code: Int,
+    val message: String
+)

clients/osv/src/main/kotlin/OsvService.kt

@@ -67,7 +67,14 @@ class OsvService(serverUrl: String? = null, httpClient: OkHttpClient? = null) {
             val response = client.getVulnerabilityIdsForPackages(batchRequest).execute()
             val body = response.body()
 
-            if (!response.isSuccessful || body == null) return Result.failure(IOException(response.message()))
+            if (!response.isSuccessful || body == null) {
+                val errorMessage = response.errorBody()?.string()?.let {
+                    val errorResponse = OsvApiClient.JSON.decodeFromString<ErrorResponse>(it)
+                    "Error code ${errorResponse.code}: ${errorResponse.message}"
+                } ?: with(response) { "HTTP code ${code()}: ${message()}" }
+
+                return Result.failure(IOException(errorMessage))
+            }
 
             result += body.results.map { batchResponse ->
                 batchResponse.vulnerabilities.mapTo(mutableListOf()) { it.id }