test(spdx): Make the schema validation more strict

The previously used schema validation of kotest lacks support for a
couple of features, such as enums, see [1]. The validation would not
flag issues with wrong values for the category of external references,
for example `PACKAGE_MANAGER` vs. `PACKAGE-MANAGER`.

Make use of `matchJsonSchema()` to also cover enum checks with the
assertion.

[1]: https://github.com/networknt/json-schema-validator/blob/master/README.md

Signed-off-by: Frank Viernau <[email protected]>

Author: fviernau

plugins/reporters/spdx/build.gradle.kts

@@ -39,7 +39,6 @@ dependencies {
     implementation(libs.jackson.databind)
 
     funTestImplementation(testFixtures(projects.plugins.reporters.spdxReporter))
-    funTestImplementation(libs.kotest.assertions.json)
 
     testFixturesImplementation(projects.utils.testUtils)
 }

plugins/reporters/spdx/src/funTest/kotlin/SpdxDocumentReporterFunTest.kt

@@ -19,8 +19,6 @@
 
 package org.ossreviewtoolkit.plugins.reporters.spdx
 
-import io.kotest.assertions.json.schema.parseSchema
-import io.kotest.assertions.json.schema.shouldMatchSchema
 import io.kotest.common.ExperimentalKotest
 import io.kotest.core.TestConfiguration
 import io.kotest.core.spec.style.WordSpec
@@ -38,6 +36,7 @@ import org.ossreviewtoolkit.utils.spdxdocument.SpdxModelMapper.FileFormat
 import org.ossreviewtoolkit.utils.spdxdocument.SpdxModelMapper.fromJson
 import org.ossreviewtoolkit.utils.spdxdocument.SpdxModelMapper.fromYaml
 import org.ossreviewtoolkit.utils.spdxdocument.model.SpdxDocument
+import org.ossreviewtoolkit.utils.test.matchJsonSchema
 import org.ossreviewtoolkit.utils.test.patchExpectedResult
 import org.ossreviewtoolkit.utils.test.readOrtResult
 import org.ossreviewtoolkit.utils.test.readResource
@@ -46,11 +45,11 @@ class SpdxDocumentReporterFunTest : WordSpec({
     "Reporting to JSON" should {
         @OptIn(ExperimentalKotest::class)
         "create a valid document" {
-            val schema = parseSchema(readResource("/spdx-v2.2.2-schema.json"))
+            val schemaJson = readResource("/spdx-v2.2.2-schema.json")
 
             val jsonSpdxDocument = generateReport(ORT_RESULT, FileFormat.JSON)
 
-            jsonSpdxDocument shouldMatchSchema schema
+            jsonSpdxDocument should matchJsonSchema(schemaJson)
         }
 
         "create the expected document for a synthetic scan result" {