chore(model): Allow the vcsPath receiver to be null

This allows to simplify code a bit.

Signed-off-by: Sebastian Schuberth <[email protected]>

Author: sschuberth

model/src/main/kotlin/utils/Extensions.kt

@@ -41,7 +41,7 @@ fun TextLocation.prependPath(prefix: String): TextLocation =
 /**
  * Return the VCS path if this is a [RepositoryProvenance] or else an empty string.
  */
-val Provenance.vcsPath: String
+val Provenance?.vcsPath: String
     get() = (this as? RepositoryProvenance)?.vcsInfo?.path.orEmpty()
 
 /**

scanner/src/main/kotlin/Scanner.kt

@@ -803,7 +803,7 @@ private fun ScanController.getSubRepositories(id: Identifier): Map<String, VcsIn
 private fun ProvenanceResolutionResult.filterByVcsPath(): ProvenanceResolutionResult =
     copy(
         subRepositories = subRepositories.filter { (path, _) ->
-            File(path).startsWith(packageProvenance?.vcsPath.orEmpty())
+            File(path).startsWith(packageProvenance.vcsPath)
         }
     )
 

scanner/src/main/kotlin/utils/Utils.kt

@@ -45,7 +45,7 @@ internal fun requireEmptyVcsPath(provenance: Provenance) {
 fun getVcsPathsForProvenances(provenances: Set<ProvenanceResolutionResult>) =
     buildMap<KnownProvenance, MutableSet<String>> {
         provenances.forEach { provenance ->
-            val packageVcsPath = provenance.packageProvenance?.vcsPath.orEmpty()
+            val packageVcsPath = provenance.packageProvenance.vcsPath
 
             provenance.getKnownProvenancesWithoutVcsPath().forEach { (repositoryPath, provenance) ->
                 getVcsPathForRepositoryOrNull(packageVcsPath, repositoryPath)?.let { vcsPath ->