fix(conan): Adapt the Conan package manager to use the virtual environments

Signed-off-by: Nicolas Nobelis <[email protected]>

Author: nnobelis

plugins/package-managers/conan/src/funTest/kotlin/ConanFunTest.kt

@@ -30,8 +30,12 @@ import org.ossreviewtoolkit.utils.test.matchExpectedResult
 import org.ossreviewtoolkit.utils.test.patchActualResult
 
 /**
- * This test class performs tests with both Conan 1 and Conan 2. For it to be successful, it needs both a "conan"
- * command for Conan 1 and a "conan2" command for Conan 2 in the PATH environment variable (as in ORT Docker image).
+ * This test class performs tests with both Conan 1 and Conan 2. To be able to run it locally, it needs to have access
+ * to some Conan installations as it is done in the ORT Docker image:
+ * - prerequisites: bash, pyenv, pyenv virtualenv.
+ * - a directory ~/bin/ort-conan containing the file 'setup_conan.sh' renamed 'conan' and made executable.
+ * - two pyenv venvs 'conan' and 'conan2' containing respectively the conan 1 and conan 2 installations.
+ * Then the test can be run with PATH set to ~/bin/ort-conan:$PATH (and the PATH of the pyenv installation).
  *
  * A word of caution about Conan 2 tests: If there is no lockfile, when Conan resolves the dependencies it read its
  * cache and relies on the package name, ignoring the version. This means, for instance, that if a test reported

plugins/package-managers/conan/src/main/kotlin/Conan.kt

@@ -56,6 +56,7 @@ import org.ossreviewtoolkit.plugins.api.OrtPlugin
 import org.ossreviewtoolkit.plugins.api.OrtPluginOption
 import org.ossreviewtoolkit.plugins.api.PluginDescriptor
 import org.ossreviewtoolkit.utils.common.CommandLineTool
+import org.ossreviewtoolkit.utils.common.ProcessCapture
 import org.ossreviewtoolkit.utils.common.alsoIfNull
 import org.ossreviewtoolkit.utils.common.masked
 import org.ossreviewtoolkit.utils.common.safeDeleteRecursively
@@ -69,7 +70,7 @@ import org.semver4j.RangesList
 import org.semver4j.RangesListFactory
 
 internal class ConanCommand(private val useConan2: Boolean = false) : CommandLineTool {
-    override fun command(workingDir: File?) = if (useConan2) "conan2" else "conan"
+    override fun command(workingDir: File?) = "conan"
 
     override fun transformVersion(output: String) =
         // Conan could report version strings like:
@@ -78,8 +79,15 @@ internal class ConanCommand(private val useConan2: Boolean = false) : CommandLin
 
     override fun getVersionRequirement(): RangesList = RangesListFactory.create(">=1.44.0 <3.0")
 
-    override fun run(vararg args: CharSequence, workingDir: File?, environment: Map<String, String>) =
-        super.run(args = args, workingDir, environment + mapOf("CONAN_NON_INTERACTIVE" to "1", "CONAN_SERIES" to "1"))
+    override fun run(vararg args: CharSequence, workingDir: File?, environment: Map<String, String>): ProcessCapture =
+        super.run(
+            args = args,
+            workingDir,
+            environment + mapOf(
+                "CONAN_NON_INTERACTIVE" to "1",
+                "CONAN_SERIES" to if (useConan2) "2" else "1"
+            )
+        )
 }
 
 data class ConanConfig(