feat(utils): Split installJdk in two functions

Move the download logic to a separate function, allowing direct download
of a specific JDK and not depending solely on Foojay Disco results.

Signed-off-by: Helio Chissini de Castro <[email protected]>

Author: heliocastro

utils/ort/src/main/kotlin/JavaBootstrapper.kt

@@ -131,21 +131,27 @@ object JavaBootstrapper {
             return Result.failure(it)
         }
 
-        val installDir = (ortToolsDirectory / "jdks" / pkg.distribution / pkg.distributionVersion)
-            .apply {
-                if (isDirectory) {
-                    logger.info { "Not downloading the JDK again as the directory '$this' already exists." }
-                    return Result.success(singleContainedDirectoryOrThis())
-                }
-
-                safeMkdirs()
+        return downloadJdk(pkg.links.pkgDownloadRedirect, pkg.distribution, pkg.distributionVersion)
+    }
+
+    /**
+     * Download the resolved JDK Url and return its directory on success, or an exception on failure.
+     */
+    fun downloadJdk(sdkUrl: String, distribution: String, distributionVersion: String): Result<File> {
+        val installDir = (ortToolsDirectory / "jdks" / distribution / distributionVersion)
+        .apply {
+            if (isDirectory) {
+                logger.info { "Not downloading the JDK again as the directory '$this' already exists." }
+                return Result.success(singleContainedDirectoryOrThis())
             }
 
-        val url = pkg.links.pkgDownloadRedirect
-        logger.info { "Downloading the JDK package from $url..." }
+            safeMkdirs()
+        }
+
+        logger.info { "Downloading the JDK package from $sdkUrl..." }
 
         val (archive, downloadDuration) = measureTimedValue {
-            okHttpClient.downloadFile(url, installDir).getOrElse {
+            okHttpClient.downloadFile(sdkUrl, installDir).getOrElse {
                 return Result.failure(it)
             }
         }