test(scanner): Move assets to resources

This is part of #8589.

Signed-off-by: Sebastian Schuberth <[email protected]>

Author: sschuberth

plugins/scanners/scancode/src/test/kotlin/ScanCodeResultParserTest.kt

@@ -28,23 +28,23 @@ import io.kotest.matchers.should
 import io.kotest.matchers.shouldBe
 import io.kotest.matchers.string.shouldStartWith
 
-import java.io.File
 import java.time.Instant
 
 import org.ossreviewtoolkit.model.Issue
 import org.ossreviewtoolkit.model.LicenseFinding
 import org.ossreviewtoolkit.model.ScanSummary
 import org.ossreviewtoolkit.model.Severity
 import org.ossreviewtoolkit.model.TextLocation
+import org.ossreviewtoolkit.utils.test.readResource
 import org.ossreviewtoolkit.utils.test.transformingCollectionMatcher
 
 class ScanCodeResultParserTest : FreeSpec({
     "generateSummary()" - {
         "for ScanCode 32.0.8 should" - {
             "get license mappings even without '--license-references'" {
-                val resultFile = getAssetFile("scancode-32.0.8_spdx-expression-parse_no-license-references.json")
+                val result = readResource("/scancode-32.0.8_spdx-expression-parse_no-license-references.json")
 
-                val summary = parseResult(resultFile).toScanSummary()
+                val summary = parseResult(result).toScanSummary()
 
                 with(summary.licenseFindings) {
                     shouldHaveSize(18)
@@ -54,9 +54,9 @@ class ScanCodeResultParserTest : FreeSpec({
             }
 
             "get file-level findings with the 'preferFileLicense' option" {
-                val resultFile = getAssetFile("scancode-32.0.8_spdx-expression-parse_no-license-references.json")
+                val result = readResource("/scancode-32.0.8_spdx-expression-parse_no-license-references.json")
 
-                val summary = parseResult(resultFile).toScanSummary(preferFileLicense = true)
+                val summary = parseResult(result).toScanSummary(preferFileLicense = true)
 
                 summary.licenseFindings.map { it.license.toString() } should containExactlyInAnyOrder(
                     "LicenseRef-scancode-generic-cla AND MIT",
@@ -70,9 +70,9 @@ class ScanCodeResultParserTest : FreeSpec({
 
         "for ScanCode 32.1.0 should" - {
             "contain findings that stem from referenced files" {
-                val resultFile = getAssetFile("scancode-32.1.0_from_file-reference.json")
+                val result = readResource("/scancode-32.1.0_from_file-reference.json")
 
-                val summary = parseResult(resultFile).toScanSummary()
+                val summary = parseResult(result).toScanSummary()
 
                 summary.licenseFindings should containExactlyInAnyOrder(
                     LicenseFinding(
@@ -150,7 +150,7 @@ class ScanCodeResultParserTest : FreeSpec({
         }
 
         for (version in 1..MAX_SUPPORTED_OUTPUT_FORMAT_MAJOR_VERSION) {
-            val resultFile = getAssetFile("scancode-output-format-$version.0.0_mime-types-2.1.18.json")
+            val resultFile = readResource("/scancode-output-format-$version.0.0_mime-types-2.1.18.json")
             val summary = parseResult(resultFile).toScanSummary()
 
             "for output format $version.0.0 should" - {
@@ -255,5 +255,3 @@ private fun containCopyrightsExactly(vararg copyrights: Pair<String, List<TextLo
         summary.copyrightFindings.groupBy { it.statement }.entries
             .map { (key, value) -> key to value.map { it.location } }
     }
-
-private fun getAssetFile(path: String): File = File("src/test/assets", path).absoluteFile

plugins/scanners/scancode/src/test/kotlin/ScanCodeTest.kt

@@ -37,6 +37,8 @@ import org.ossreviewtoolkit.model.PackageType
 import org.ossreviewtoolkit.model.ScannerDetails
 import org.ossreviewtoolkit.scanner.ScanContext
 import org.ossreviewtoolkit.utils.common.ProcessCapture
+import org.ossreviewtoolkit.utils.common.extractResource
+import org.ossreviewtoolkit.utils.test.readResource
 
 class ScanCodeTest : WordSpec({
     val scanner = ScanCodeFactory.create()
@@ -86,9 +88,8 @@ class ScanCodeTest : WordSpec({
 
             val scannerSpy = spyk(scanner)
             every { scannerSpy.runScanCode(any(), any()) } answers {
-                val resultFile = File("src/test/assets/scancode-with-issues.json")
                 val targetFile = secondArg<File>()
-                resultFile.copyTo(targetFile)
+                extractResource("/scancode-with-issues.json", targetFile)
 
                 process
             }
@@ -126,8 +127,7 @@ class ScanCodeTest : WordSpec({
 
     "parseDetails()" should {
         "return details for a raw scan result" {
-            val resultFile = File("src/test/assets/scancode-with-issues.json")
-            val result = resultFile.readText()
+            val result = readResource("/scancode-with-issues.json")
 
             scanner.parseDetails(result) shouldBe ScannerDetails(
                 name = "ScanCode",

plugins/scanners/scancode/src/test/assets/scancode-32.0.8_spdx-expression-parse_no-license-references.json renamed to plugins/scanners/scancode/src/test/resources/scancode-32.0.8_spdx-expression-parse_no-license-references.json

@@ -28,7 +28,6 @@ import io.kotest.matchers.collections.haveSize
 import io.kotest.matchers.collections.shouldContain
 import io.kotest.matchers.should
 
-import java.io.File
 import java.time.Instant
 
 import org.ossreviewtoolkit.model.CopyrightFinding
@@ -40,11 +39,12 @@ import org.ossreviewtoolkit.model.TextLocation
 import org.ossreviewtoolkit.model.VcsInfo
 import org.ossreviewtoolkit.model.VcsType
 import org.ossreviewtoolkit.utils.spdx.SpdxExpression
+import org.ossreviewtoolkit.utils.test.readResource
 
 class ScanOssResultParserTest : WordSpec({
     "generateSummary()" should {
         "properly summarize JUnit 4.12 findings" {
-            val results = File("src/test/assets/scanoss-junit-4.12.json").readText().let {
+            val results = readResource("/scanoss-junit-4.12.json").let {
                 JsonUtils.toScanFileResultsFromObject(JsonUtils.toJsonObject(it))
             }
 
@@ -82,7 +82,7 @@ class ScanOssResultParserTest : WordSpec({
         }
 
         "properly summarize Semver4j 3.1.0 with snippet findings" {
-            val results = File("src/test/assets/scanoss-semver4j-3.1.0-with-snippet.json").readText().let {
+            val results = readResource("/scanoss-semver4j-3.1.0-with-snippet.json").let {
                 JsonUtils.toScanFileResultsFromObject(JsonUtils.toJsonObject(it))
             }