fix(node): Fall back to any single enabled node package manager

If the Node package manager cannot be detected, use the first enabled one
(according to the ordering in `NodePackageManagerType`) as a fallback
instead of always falling back to NPM (which might not be enabled).

Signed-off-by: Sebastian Schuberth <[email protected]>

Author: sschuberth

plugins/package-managers/node/src/main/kotlin/NodePackageManager.kt

@@ -25,6 +25,7 @@ import org.apache.logging.log4j.kotlin.logger
 
 import org.ossreviewtoolkit.analyzer.PackageManager
 import org.ossreviewtoolkit.analyzer.PackageManagerResult
+import org.ossreviewtoolkit.analyzer.determineEnabledPackageManagers
 import org.ossreviewtoolkit.analyzer.parseAuthorString
 import org.ossreviewtoolkit.downloader.VersionControlSystem
 import org.ossreviewtoolkit.model.Identifier
@@ -77,7 +78,17 @@ abstract class NodePackageManager(val managerType: NodePackageManagerType) : Pac
         analysisRoot: File,
         definitionFiles: List<File>,
         analyzerConfig: AnalyzerConfiguration
-    ) = NodePackageManagerDetection(definitionFiles).filterApplicable(managerType)
+    ): List<File> {
+        val enabledIds = analyzerConfig.determineEnabledPackageManagers().map { it.descriptor.id.uppercase() }
+
+        // Only keep those types for which a package manager is enabled.
+        val enabledTypes = NodePackageManagerType.entries.filter { it.name in enabledIds }
+
+        // Assume the first type to be the best candidate for the fallback.
+        val fallbackType = enabledTypes.first()
+
+        return NodePackageManagerDetection(definitionFiles).filterApplicable(managerType, fallbackType)
+    }
 
     override fun createPackageManagerResult(projectResults: Map<File, List<ProjectAnalyzerResult>>) =
         PackageManagerResult(projectResults, graphBuilder.build(), graphBuilder.packages())

plugins/package-managers/node/src/main/kotlin/npm/Npm.kt

@@ -100,6 +100,8 @@ class Npm(override val descriptor: PluginDescriptor = NpmFactory.descriptor, pri
         definitionFiles: List<File>,
         analyzerConfig: AnalyzerConfiguration
     ) {
+        super.beforeResolution(analysisRoot, definitionFiles, analyzerConfig)
+
         NpmCommand.checkVersion()
 
         val directories = definitionFiles.mapTo(mutableSetOf()) { it.resolveSibling("node_modules") }

plugins/package-managers/node/src/main/kotlin/pnpm/Pnpm.kt

@@ -75,6 +75,8 @@ class Pnpm(override val descriptor: PluginDescriptor = PnpmFactory.descriptor) :
         definitionFiles: List<File>,
         analyzerConfig: AnalyzerConfiguration
     ) {
+        super.beforeResolution(analysisRoot, definitionFiles, analyzerConfig)
+
         PnpmCommand.checkVersion()
 
         val directories = definitionFiles.mapTo(mutableSetOf()) { it.resolveSibling("node_modules") }

plugins/package-managers/node/src/main/kotlin/yarn/Yarn.kt

@@ -84,6 +84,8 @@ class Yarn(override val descriptor: PluginDescriptor = YarnFactory.descriptor) :
         definitionFiles: List<File>,
         analyzerConfig: AnalyzerConfiguration
     ) {
+        super.beforeResolution(analysisRoot, definitionFiles, analyzerConfig)
+
         YarnCommand.checkVersion()
 
         val directories = definitionFiles.mapTo(mutableSetOf()) { it.resolveSibling("node_modules") }

plugins/package-managers/node/src/main/kotlin/yarn2/Yarn2.kt

@@ -90,7 +90,13 @@ class Yarn2(override val descriptor: PluginDescriptor = Yarn2Factory.descriptor,
         analysisRoot: File,
         definitionFiles: List<File>,
         analyzerConfig: AnalyzerConfiguration
-    ) = definitionFiles.forEach { yarn2Command.checkVersion(it.parentFile) }
+    ) {
+        super.beforeResolution(analysisRoot, definitionFiles, analyzerConfig)
+
+        definitionFiles.forEach {
+            yarn2Command.checkVersion(it.parentFile)
+        }
+    }
 
     override fun resolveDependencies(
         analysisRoot: File,