Skip to content

Commit b71d16f

Browse files
committed
docs(Composer): Improve the comment about filtering vendored dependencies
Better explain the idea behind the algorithm, also to highlight the difference to similar code in the `GoMod` analyzer [1], which omits definition files also from "vendor" directories that do not have another definition file as a sibling. [1]: https://github.com/oss-review-toolkit/ort/blob/01f19307c486f63012ad8b86c08f323622d87abd/plugins/package-managers/go/src/main/kotlin/GoMod.kt#L104-L111 Signed-off-by: Sebastian Schuberth <[email protected]>
1 parent 2d5e526 commit b71d16f

File tree

1 file changed

+2
-1
lines changed
  • plugins/package-managers/composer/src/main/kotlin

1 file changed

+2
-1
lines changed

plugins/package-managers/composer/src/main/kotlin/Composer.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,8 @@ class Composer(
112112
override fun mapDefinitionFiles(definitionFiles: List<File>): List<File> {
113113
val projectFiles = definitionFiles.toMutableList()
114114

115-
// Ignore definition files from vendored dependencies to avoid them being recognized as projects.
115+
// Ignore definition files from vendor directories that reside next to other definition files, to avoid the
116+
// former from being recognized as projects.
116117
var index = 0
117118
while (index < projectFiles.size - 1) {
118119
val projectFile = projectFiles[index++]

0 commit comments

Comments
 (0)