chore: Replace !! with checkNotNull() in test code

`checkNotNull()` has clearer semantics and avoids Detekt issues.

Signed-off-by: Sebastian Schuberth <[email protected]>

Author: sschuberth

downloader/src/funTest/kotlin/VersionControlSystemFunTest.kt

@@ -41,7 +41,7 @@ class VersionControlSystemFunTest : WordSpec({
     val absProjDir = relProjDir.absoluteFile
 
     "For an absolute working directory, getPathToRoot()" should {
-        val absVcsDir = VersionControlSystem.forDirectory(absProjDir)!!
+        val absVcsDir = checkNotNull(VersionControlSystem.forDirectory(absProjDir))
 
         "work if given absolute paths" {
             absVcsDir.getPathToRoot(vcsRoot) shouldBe ""
@@ -57,7 +57,7 @@ class VersionControlSystemFunTest : WordSpec({
     }
 
     "For a relative working directory, getPathToRoot()" should {
-        val relVcsDir = VersionControlSystem.forDirectory(relProjDir)!!
+        val relVcsDir = checkNotNull(VersionControlSystem.forDirectory(relProjDir))
 
         "work if given absolute paths" {
             relVcsDir.getPathToRoot(vcsRoot) shouldBe ""

utils/test/src/main/kotlin/Matchers.kt

@@ -92,7 +92,7 @@ fun matchExpectedResult(
     if (multiLineDiff != "unified") return EqMatcher(expected)
 
     return Matcher { actual ->
-        val vcsDir = VersionControlSystem.forDirectory(expectedResultFile)!!
+        val vcsDir = checkNotNull(VersionControlSystem.forDirectory(expectedResultFile))
         val relativeExpectedResultFile = vcsDir.getPathToRoot(expectedResultFile)
 
         val expectedLines = expected.lines()

utils/test/src/main/kotlin/Utils.kt

@@ -89,7 +89,7 @@ fun patchExpectedResult(
 
         if (definitionFile != null) {
             val projectDir = definitionFile.parentFile
-            val vcsDir = VersionControlSystem.forDirectory(projectDir)!!
+            val vcsDir = checkNotNull(VersionControlSystem.forDirectory(projectDir))
             val url = vcsDir.getRemoteUrl()
             val path = vcsDir.getPathToRoot(projectDir)