chore(pub): Rework setting package properties a bit

Make properties that are in any case set `lateinit` and reorder them for
readability.

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>

Author: sschuberth

plugins/package-managers/pub/src/main/kotlin/Pub.kt

@@ -623,12 +623,12 @@ class Pub(override val descriptor: PluginDescriptor = PubFactory.descriptor, pri
             packageInfo.source != "sdk"
         }.forEach { (packageName, packageInfo) ->
             runCatching {
-                val version = packageInfo.version.orEmpty()
+                lateinit var rawName: String
+                lateinit var vcs: VcsInfo
+
+                var authors = emptySet<String>()
                 var description = ""
-                var rawName = ""
                 var homepageUrl = ""
-                var vcs = VcsInfo.EMPTY
-                var authors = emptySet<String>()
 
                 val source = packageInfo.source
 
@@ -650,9 +650,9 @@ class Pub(override val descriptor: PluginDescriptor = PubFactory.descriptor, pri
                         val pkgInfoFromYamlFile = readPackageInfoFromCache(packageInfo, workingDir)
 
                         rawName = pkgInfoFromYamlFile?.name ?: packageName
+                        authors = pkgInfoFromYamlFile?.let { parseAuthors(it) }.orEmpty()
                         description = pkgInfoFromYamlFile?.description.orEmpty().trim()
                         homepageUrl = pkgInfoFromYamlFile?.homepage.orEmpty()
-                        authors = pkgInfoFromYamlFile?.let { parseAuthors(it) }.orEmpty()
 
                         vcs = VcsInfo(
                             type = VcsType.GIT,
@@ -666,9 +666,9 @@ class Pub(override val descriptor: PluginDescriptor = PubFactory.descriptor, pri
                         val pkgInfoFromYamlFile = readPackageInfoFromCache(packageInfo, workingDir)
 
                         rawName = pkgInfoFromYamlFile?.name.orEmpty()
+                        authors = pkgInfoFromYamlFile?.let { parseAuthors(it) }.orEmpty()
                         description = pkgInfoFromYamlFile?.description.orEmpty().trim()
                         homepageUrl = pkgInfoFromYamlFile?.homepage.orEmpty()
-                        authors = pkgInfoFromYamlFile?.let { parseAuthors(it) }.orEmpty()
 
                         val repositoryUrl = pkgInfoFromYamlFile?.repository.orEmpty()
 
@@ -685,18 +685,20 @@ class Pub(override val descriptor: PluginDescriptor = PubFactory.descriptor, pri
                         containsFlutter = true
                         // Set hardcoded package details.
                         rawName = "flutter"
-                        homepageUrl = "https://github.com/flutter/flutter"
                         description = "Flutter SDK"
+                        homepageUrl = "https://github.com/flutter/flutter"
                     }
 
                     "flutter_test" -> {
                         // Set hardcoded package details.
                         rawName = "flutter_test"
-                        homepageUrl = "https://github.com/flutter/flutter/tree/master/packages/flutter_test"
                         description = "Flutter Test SDK"
+                        homepageUrl = "https://github.com/flutter/flutter/tree/master/packages/flutter_test"
                     }
                 }
 
+                val version = packageInfo.version.orEmpty()
+
                 if (version.isEmpty()) {
                     logger.warn { "No version information found for package $rawName." }
                 }